Skip to content

fix(clp-mcp-server): Add clp-py-utils as a clp-mcp-server's dependency for running unit tests. #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(clp-mcp-server): Add clp-py-utils as a clp-mcp-server's dependency for running unit tests. #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/clp-mcp-server/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ dependencies = [
"msgpack>=1.1.2",
"paginate>=0.5.7",
"pymongo>=4.15.3",
"clp-py-utils",
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Add version constraint for clp-py-utils dependency.

The clp-py-utils dependency lacks a version constraint, inconsistent with all other dependencies in this file (e.g., aiomysql>=0.2.0, click>=8.3.0). Even for local editable dependencies, specifying a version constraint improves reproducibility and clarity.

Based on learnings from PR #1271, the repository prefers lower bound version constraints (e.g., >=X.Y.Z).

Please verify the appropriate version constraint for clp-py-utils and update line 15 to include it:

-    "clp-py-utils",
+    "clp-py-utils>=VERSION",

Additionally, run the following script to verify the repository structure and the clp-py-utils directory location:

🏁 Script executed:

#!/bin/bash
# Description: Verify clp-py-utils directory exists and contains a valid pyproject.toml

# Check if clp-py-utils directory exists at the expected path
if [ -d "components/clp-py-utils" ]; then
    echo "✓ clp-py-utils directory found"
    # Verify it contains a pyproject.toml
    if [ -f "components/clp-py-utils/pyproject.toml" ]; then
        echo "✓ pyproject.toml exists in clp-py-utils"
        # Extract version from clp-py-utils pyproject.toml
        grep "^version" components/clp-py-utils/pyproject.toml
    else
        echo "✗ pyproject.toml not found in clp-py-utils"
    fi
else
    echo "✗ clp-py-utils directory not found at components/clp-py-utils"
fi

Length of output: 92

🏁 Script executed:

#!/bin/bash
# View the full pyproject.toml for clp-mcp-server to verify dependency constraints
echo "=== clp-mcp-server/pyproject.toml ==="
cat components/clp-mcp-server/pyproject.toml

echo -e "\n=== Check for similar patterns in other pyproject.toml files ==="
# Find all pyproject.toml files with [tool.uv.sources]
fd -e pyproject.toml -x grep -l "tool.uv.sources" {}

Length of output: 2661

Add version constraint for clp-py-utils dependency to maintain consistency.

The clp-py-utils dependency (line 15) lacks a version constraint, while all other dependencies specify lower bound constraints (e.g., aiomysql>=0.2.0, click>=8.3.0). Even when using editable local sources via [tool.uv.sources], including a version constraint improves reproducibility and aligns with the repository's established pattern (as documented in PR #1271).

Update line 15:

-    "clp-py-utils",
+    "clp-py-utils>=0.5.2",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"clp-py-utils",
"clp-py-utils>=0.5.2",
🤖 Prompt for AI Agents 
In components/clp-mcp-server/pyproject.toml around line 15, the clp-py-utils
dependency has no version constraint; update that entry to include a lower-bound
version constraint consistent with other deps (e.g., use the repository's
current package version or the minimum supported version from PR #1271 such as
>=0.1.0) so the dependency line matches the project's pattern and improves
reproducibility.

]

[tool.uv.sources]
clp-py-utils = { path = "../clp-py-utils", editable = true }

[project.scripts]
clp-mcp-server = "clp_mcp_server.clp_mcp_server:main"

Expand Down
Loading
Loading