Skip to content

Conversation

@junhaoliao
Copy link
Member

Description

Fixed the _get_num_workers() method in controller.py to ensure at least 1 worker is returned, even on single-CPU systems. The error in the equation has long existed and was moved from start_clp.py in #1178 .

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

In WSL Ubuntu

task

Then changed the processors setting to 1: https://learn.microsoft.com/en-us/windows/wsl/wsl-config#main-wsl-settings ; restarted wsl

cd <project-root>
cd build/clp-package
./sbin/start-clp.sh
./sbin/compress.sh ~/samples/hive-24hr
# observed the compression completed successfully

# performed a search with string "1" in the webui and observed results were returned and the timeline was correctly displayed

@junhaoliao junhaoliao requested a review from a team as a code owner November 4, 2025 02:23
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Warning

Rate limit exceeded

@junhaoliao has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 12 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between ad7cffe and 818cd11.

📒 Files selected for processing (1)
  • components/clp-package-utils/clp_package_utils/controller.py (1 hunks)
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@Eden-D-Zhang Eden-D-Zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@junhaoliao junhaoliao merged commit 6d04055 into y-scope:main Nov 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants