fix(clp-package): Ensure at least one worker in default calculations (fixes #1509). #1547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the
_get_num_workers()method in controller.py to ensure at least 1 worker is returned, even on single-CPU systems. The error in the equation has long existed and was moved from start_clp.py in #1178 .Checklist
breaking change.
Validation performed
In WSL Ubuntu
Then changed the
processorssetting to1: https://learn.microsoft.com/en-us/windows/wsl/wsl-config#main-wsl-settings ; restarted wsl