Skip to content

feat(clp-s::timestamp_parser): Add support for parsing date-time and epoch timestamps without timezones. #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
+610 −25
Open

feat(clp-s::timestamp_parser): Add support for parsing date-time and epoch timestamps without timezones. #1564

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3e948c5
Implement remaining format specifiers except for timezone and CAT seq…
gibber9809 Nov 3, 2025
09ff6fb
Cover some missed edge cases in TimestampParser
gibber9809 Nov 5, 2025
7a8d504
Add tests that ensure that newly implemented format specifiers accept…
gibber9809 Nov 5, 2025
0d28cf6
Add tests for basic timestamp patterns; fix bug in millisecond and mi…
gibber9809 Nov 5, 2025
f8a288f
Add tests for all timestamps from test-TimestampPattern.cpp plus comm…
gibber9809 Nov 6, 2025
4fd8fe6
Add missing const.
gibber9809 Nov 6, 2025
9b58db2
Fix clang-tidy errors in test_TimestampParser.cpp
gibber9809 Nov 6, 2025
b2d91c8
Merge remote-tracking branch 'upstream/main' into timestamp-parser-2
gibber9809 Nov 6, 2025
64ed11b
Apply suggestions from code review
gibber9809 Nov 10, 2025
d533f35
Address most review comments.
gibber9809 Nov 10, 2025
db68ff6
Address more review comments.
gibber9809 Nov 10, 2025
d8a68b0
Add inline comments about each format specifier.
gibber9809 Nov 10, 2025
48a1b4c
Move expected parsing cases into only test section that currently use…
gibber9809 Nov 10, 2025
9558d74
Merge remote-tracking branch 'upstream/main' into timestamp-parser-2
gibber9809 Nov 10, 2025
7f41e7d
Address rabbit comment.
gibber9809 Nov 10, 2025
1875c75
Use constexpr power of 10 in a few more instances.
gibber9809 Nov 10, 2025
eaf6825
Fix clang-tidy issue in TimestampParser
gibber9809 Nov 10, 2025
408c0fd
Address edge case caught by rabbit.
gibber9809 Nov 10, 2025
29fc82e
Merge remote-tracking branch 'upstream/main' into timestamp-parser-2
gibber9809 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading