Skip to content

Conversation

@junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Dec 26, 2025

Description

Update the MongoDB health check command for the results-cache service in docker-compose-all.yaml to use --eval instead of shell piping, to align with the Helm chart implementation in results-cache-statefulset.yaml.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Confirmed the updated health check command matches the Helm chart implementation in
    tools/deployment/package-helm/templates/results-cache-statefulset.yaml.
task
cd build/clp-package
./sbin/start-clp.sh

# observed the package was started successfully

docker inspect --format='{{json .State.Health}}' clp-package-b428-results-cache-1
# {"Status":"healthy","FailingStreak":0,"Log":[{"Start":"2025-12-31T23:41:14.65808779-05:00","End":"2025-12-31T23:41:15.071793381-05:00","ExitCode":0,"Output":"1\n"},{"Start":"2025-12-31T23:41:45.072553412-05:00","End":"2025-12-31T23:41:45.348148983-05:00","ExitCode":0,"Output":"1\n"},{"Start":"2025-12-31T23:42:15.349233955-05:00","End":"2025-12-31T23:42:15.610848527-05:00","ExitCode":0,"Output":"1\n"},{"Start":"2025-12-31T23:42:45.611562539-05:00","End":"2025-12-31T23:42:45.87316694-05:00","ExitCode":0,"Output":"1\n"}]}
# observed health checks were successful

Summary by CodeRabbit

  • Chores
    • Updated deployment health monitoring for the results-cache service to use a direct database client check, improving accuracy and reliability of status reporting during service updates.

✏️ Tip: You can customize this high-level summary in your review settings.


@junhaoliao junhaoliao requested a review from a team as a code owner December 26, 2025 12:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

Walkthrough

The results-cache service healthcheck in the Docker Compose configuration was modified to replace a shell-piped mongosh command with a direct mongosh invocation using the --quiet and --eval db.runCommand('ping').ok flags.

Changes

Cohort / File(s) Change Summary
Deployment Configuration
tools/deployment/package/docker-compose-all.yaml
Replaced results-cache healthcheck CMD-SHELL that piped an echo into mongosh with CMD invoking mongosh directly: mongosh host:port --quiet --eval db.runCommand('ping').ok

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the MongoDB health check command for the results-cache service in the Docker Compose configuration file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junhaoliao junhaoliao added this to the Backlog milestone Jan 19, 2026
@junhaoliao junhaoliao modified the milestones: Backlog, February 2026 Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant