Skip to content

Conversation

@junhaoliao
Copy link
Member

@junhaoliao junhaoliao commented Dec 26, 2025

Description

This PR fixes an issue where archive_garbage_collector.py was writing its recovery file to the logs directory (clp_config.logs_directory) instead of the temporary directory.

This aligns with the project's convention of using dedicated temporary directories for temporary files.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Verified that clp_config.tmp_directory is set to /var/tmp in both Docker Compose and Helm deployments.
  • Confirmed the Docker Compose garbage-collector service now has the /var/tmp volume mount.
  • Confirmed the Helm deployment mounts the tmp emptyDir at /var/tmp.

@junhaoliao junhaoliao requested a review from a team as a code owner December 26, 2025 12:15
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 26, 2025

Warning

Rate limit exceeded

@junhaoliao has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between d1f88ee and e65a8b4.

📒 Files selected for processing (3)
  • components/job-orchestration/job_orchestration/garbage_collector/archive_garbage_collector.py
  • tools/deployment/package-helm/templates/garbage-collector-deployment.yaml
  • tools/deployment/package/docker-compose-all.yaml
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@junhaoliao junhaoliao marked this pull request as draft December 26, 2025 12:19
@junhaoliao junhaoliao added this to the Backlog milestone Jan 19, 2026
@junhaoliao junhaoliao changed the title fix(job-orchestration): Move garbage collector recovery file to temporary directory (fixes #1823). WIP - change /var/tmp dir to tmpfs Jan 21, 2026
@junhaoliao junhaoliao modified the milestones: Backlog, February 2026 Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant