feat(docker): Add mirror configuration options for manylinux build containers #1849

jackluo923 · 2026-01-08T07:34:13Z

Description

Add optional mirror configuration for building manylinux Docker containers in environments with restricted network access (e.g., behind firewalls).

New environment variables for build.sh:

QUAY_MIRROR - Alternative mirror for quay.io
ALMALINUX_MIRROR - Alternative mirror for AlmaLinux packages
USE_NETWORK_HOST - Set to true to enable --network=host for builds

Example usage:

QUAY_MIRROR=quay.m.daocloud.io \
ALMALINUX_MIRROR=mirrors.aliyun.com/almalinux \
USE_NETWORK_HOST=true \
./build.sh

Checklist

The PR satisfies the contribution guidelines.
This is a breaking change and that has been indicated in the PR title, OR this isn't a breaking change.
Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Built x86_64 manylinux container successfully with custom mirrors
Built aarch64 manylinux container successfully with custom mirrors (using QEMU emulation)
Verified default behavior (no env vars set) works unchanged

Summary by CodeRabbit

Chores
- Docker image builds now support configurable package source mirrors for Quay and AlmaLinux
- Added optional network host mode for build operations

_{✏️ Tip: You can customize this high-level summary in your review settings.}

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1212888443550765

- Add ALMALINUX_MIRROR build arg for package mirrors - Add QUAY_MIRROR build arg for base image registry - Add USE_NETWORK_HOST option for --network=host mode

coderabbitai · 2026-01-08T07:34:25Z

Walkthrough

Configuration changes add build-time arguments for customizable Docker image sources across manylinux architectures. QUAY_MIRROR specifies the base image registry, ALMALINUX_MIRROR optionally overrides AlmaLinux repository mirrors, and USE_NETWORK_HOST enables network isolation during container builds. Changes applied consistently to both aarch64 and x86_64 variants.

Changes

Cohort / File(s)	Summary
Manylinux Dockerfiles (aarch64 & x86_64) `components/core/tools/docker-images/clp-env-base-manylinux_2_28-aarch64/Dockerfile`, `components/core/tools/docker-images/clp-env-base-manylinux_2_28-x86_64/Dockerfile`	Added `QUAY_MIRROR` ARG (default: quay.io) for configurable base image source in FROM directive; added `ALMALINUX_MIRROR` ARG with conditional RUN step to override AlmaLinux repository baseurl when mirror is specified.
Build Scripts (aarch64 & x86_64) `components/core/tools/docker-images/clp-env-base-manylinux_2_28-aarch64/build.sh`, `components/core/tools/docker-images/clp-env-base-manylinux_2_28-x86_64/build.sh`	Added `--build-arg QUAY_MIRROR=quay.io` and `--build-arg ALMALINUX_MIRROR` parameters to docker buildx command; added conditional `--network=host` flag when `USE_NETWORK_HOST` is true.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the primary change: adding configurable mirror options for manylinux Docker build containers.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-01-08T16:54:40Z

Caution

Docstrings generation - FAILED

No docstrings were generated.

junhaoliao

shall we update the musllinux_1_2-x86_64 and musllinux_1_2-aarch64 Dockerfiles to use QUAY_MIRROR as well?
for consistency, shall we update other build.sh to accept USE_NETWORK_HOST as well?
Let's update docs/src/dev-docs/tooling-containers.md. consider a table that describes the variable name, default and description for each. we should be clear that both ALMALINUX_MIRROR and QUAY_MIRROR should be a hostname + path, not full URLs like https://xxx

junhaoliao · 2026-01-08T18:30:27Z

components/core/tools/docker-images/clp-env-base-manylinux_2_28-aarch64/Dockerfile

+ARG ALMALINUX_MIRROR
+RUN if [ -n "${ALMALINUX_MIRROR}" ]; then \
+        sed -i -e 's|^mirrorlist=|#mirrorlist=|g' \
+               -e "s|^# baseurl=https://repo.almalinux.org|baseurl=https://${ALMALINUX_MIRROR}|g" \


just in case the maintainers decide to use different amount of spaces? it might never happen though

Suggested change

-e "s|^# baseurl=https://repo.almalinux.org|baseurl=https://${ALMALINUX_MIRROR}|g" \

-e "s|^#[[:space:]]*baseurl=https://repo.almalinux.org|baseurl=https://${ALMALINUX_MIRROR}|g" \

junhaoliao · 2026-01-08T18:31:29Z

components/core/tools/docker-images/clp-env-base-manylinux_2_28-x86_64/Dockerfile

+ARG ALMALINUX_MIRROR
+RUN if [ -n "${ALMALINUX_MIRROR}" ]; then \
+        sed -i -e 's|^mirrorlist=|#mirrorlist=|g' \
+               -e "s|^# baseurl=https://repo.almalinux.org|baseurl=https://${ALMALINUX_MIRROR}|g" \


Suggested change

-e "s|^# baseurl=https://repo.almalinux.org|baseurl=https://${ALMALINUX_MIRROR}|g" \

-e "s|^#[[:space:]]*baseurl=https://repo.almalinux.org|baseurl=https://${ALMALINUX_MIRROR}|g" \

junhaoliao · 2026-01-08T18:43:55Z

components/core/tools/docker-images/clp-env-base-manylinux_2_28-aarch64/build.sh

    docker buildx build
    --platform linux/arm64
+    --build-arg "ALMALINUX_MIRROR=${ALMALINUX_MIRROR:-}"
+    --build-arg "QUAY_MIRROR=${QUAY_MIRROR:-quay.io}"


we may not need this -quay.io fallback given we have specified so in the Dockerfile?

junhaoliao · 2026-01-08T18:49:37Z

shall we update the musllinux_1_2-x86_64 and musllinux_1_2-aarch64 Dockerfiles to use QUAY_MIRROR as well?

if the needs are clearly scoped to manylinux only, i'm fine deferring this to another PR. (let's ask the rabbit to create a follow up issue

junhaoliao · 2026-01-11T22:35:30Z

shall we update the musllinux_1_2-x86_64 and musllinux_1_2-aarch64 Dockerfiles to use QUAY_MIRROR as well?

if the needs are clearly scoped to manylinux only, i'm fine deferring this to another PR. (let's ask the rabbit to create a follow up issue

discussed offline - muslinux changes will be made in another PR

feat(docker): add build configuration options for manylinux containers

aa8f054

- Add ALMALINUX_MIRROR build arg for package mirrors - Add QUAY_MIRROR build arg for base image registry - Add USE_NETWORK_HOST option for --network=host mode

jackluo923 requested a review from a team as a code owner January 8, 2026 07:34

jackluo923 requested a review from junhaoliao January 8, 2026 07:42

Merge branch 'main' into add-mirror

402cbbf

junhaoliao requested changes Jan 8, 2026

View reviewed changes

junhaoliao modified the milestones: Backlog, February 2026 Jan 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(docker): Add mirror configuration options for manylinux build containers #1849

feat(docker): Add mirror configuration options for manylinux build containers #1849

Uh oh!

jackluo923 commented Jan 8, 2026 •

edited by junhaoliao

Loading

Uh oh!

coderabbitai bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

junhaoliao left a comment

Uh oh!

junhaoliao Jan 8, 2026

Uh oh!

junhaoliao Jan 8, 2026

Uh oh!

junhaoliao Jan 8, 2026

Uh oh!

junhaoliao commented Jan 8, 2026 •

edited

Loading

Uh oh!

junhaoliao commented Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	-e "s\|^# baseurl=https://repo.almalinux.org\|baseurl=https://${ALMALINUX_MIRROR}\|g" \
	-e "s\|^#[[:space:]]*baseurl=https://repo.almalinux.org\|baseurl=https://${ALMALINUX_MIRROR}\|g" \

feat(docker): Add mirror configuration options for manylinux build containers #1849

Are you sure you want to change the base?

feat(docker): Add mirror configuration options for manylinux build containers #1849

Uh oh!

Conversation

jackluo923 commented Jan 8, 2026 • edited by junhaoliao Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Validation performed

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junhaoliao left a comment

Choose a reason for hiding this comment

Uh oh!

junhaoliao Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

junhaoliao Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

junhaoliao Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

junhaoliao commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junhaoliao commented Jan 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jackluo923 commented Jan 8, 2026 •

edited by junhaoliao

Loading

coderabbitai bot commented Jan 8, 2026 •

edited

Loading

coderabbitai bot commented Jan 8, 2026 •

edited

Loading

junhaoliao commented Jan 8, 2026 •

edited

Loading