Skip to content

Conversation

@Bill-hbrhbr
Copy link
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Feb 10, 2026

Description

Add missing headers due to failed workflows: https://github.com/y-scope/clp/actions/runs/21885169350/job/63178113545?pr=1963

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Checked with clang-tidy.

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies to support enhanced functionality.

Note: This release includes internal infrastructure improvements with no direct user-facing changes.

@Bill-hbrhbr Bill-hbrhbr requested review from a team and gibber9809 as code owners February 10, 2026 22:54
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Walkthrough

Added two include directives to DictionaryEntry.hpp: <vector> to support std::vector usage and "ErrorCode.hpp" for ErrorCode type declarations. No structural or behavioural changes to existing code.

Changes

Cohort / File(s) Summary
Include additions
components/core/src/clp_s/DictionaryEntry.hpp
Added #include <vector> and #include "ErrorCode.hpp" to enable use of std::vector and ErrorCode types in the header file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title directly and clearly summarizes the main change: adding missing include directives to DictionaryEntry.hpp, which matches the changeset perfectly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@gibber9809 gibber9809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For PR title how about:

fix(clp-s): Add missing include directives to `DictionaryEntry.hpp.`

@Bill-hbrhbr Bill-hbrhbr changed the title fix(clp-s): Add missing headers for DictionaryEntry.hpp. fix(clp-s): Add missing include directives to DictionaryEntry.hpp. Feb 10, 2026
@Bill-hbrhbr Bill-hbrhbr merged commit 5f1d7ca into y-scope:main Feb 10, 2026
30 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the add-missing-header branch February 11, 2026 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants