-
Notifications
You must be signed in to change notification settings - Fork 88
feat(log-ingestor): Introduce an abstract State layer for fault-tolerance implementation:
#2001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LinZhihao-723
wants to merge
19
commits into
y-scope:main
Choose a base branch
from
LinZhihao-723:state-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+334
−94
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
260b3f7
Implementation done.
LinZhihao-723 ad7cf6e
Apply suggestions from code review
LinZhihao-723 1ae4401
Fix.
LinZhihao-723 5ddd1bb
WIP.
LinZhihao-723 8e4d127
WIP
LinZhihao-723 73b4ecd
Done.
LinZhihao-723 eae3f24
Merge.
LinZhihao-723 2441343
Fix merge failure.
LinZhihao-723 788dd14
Merge
LinZhihao-723 71f38c9
Remove empty line.
LinZhihao-723 3e5aa58
Bug fixing: No empty message delete.
LinZhihao-723 21f1964
Add TODO.
LinZhihao-723 41dbc39
Minor fix.
LinZhihao-723 3e89a37
Fix
LinZhihao-723 d66be0c
Merge branch 'main' into state-manager
LinZhihao-723 48cfc53
Merge branch 'main' into state-manager
LinZhihao-723 01462b6
Fix offline discussion
LinZhihao-723 4323384
Merge branch 'state-manager' of https://github.com/LinZhihao-723/clp …
LinZhihao-723 3542a48
Apply rabitt's review comment.
LinZhihao-723 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We probably need update the doc strings. How about diff --git a/components/log-ingestor/src/ingestion_job/s3_scanner.rs b/components/log-ingestor/src/ingestion_job/s3_scanner.rs
index 71f0a418..65e4deb0 100644
--- a/components/log-ingestor/src/ingestion_job/s3_scanner.rs
+++ b/components/log-ingestor/src/ingestion_job/s3_scanner.rs
@@ -73,8 +73,8 @@ impl<S3ClientManager: AwsClientManagerType<Client>, State: S3ScannerState>
}
}
- /// Scans the configured S3 bucket and prefix for new objects and sends their metadata to the
- /// underlying channel sender.
+ /// Scans the configured S3 bucket and prefix for new objects and ingests their metadata through
+ /// the underlying state.
///
/// # Note
///
@@ -168,7 +168,7 @@ impl<State: S3ScannerState> S3Scanner<State> {
/// Creates and spawns a new [`S3Scanner`] backed by a [`Task`].
///
/// This function spawns a [`Task`]. The spawned task will periodically scan the configured S3
- /// bucket and prefix for new objects and send their metadata to the provided channel sender.
+ /// bucket and prefix for new objects and ingest their metadata through the provided state.
///
/// # Type parameters
///
diff --git a/components/log-ingestor/src/ingestion_job/sqs_listener.rs b/components/log-ingestor/src/ingestion_job/sqs_listener.rs
index a3a8314b..015d4fb1 100644
--- a/components/log-ingestor/src/ingestion_job/sqs_listener.rs
+++ b/components/log-ingestor/src/ingestion_job/sqs_listener.rs
@@ -37,7 +37,7 @@ impl<SqsClientManager: AwsClientManagerType<Client>, State: SqsListenerState>
Task<SqsClientManager, State>
{
/// Runs the SQS listener task to listen to SQS messages and extract S3 object metadata. The
- /// extracted metadata is sent to the provided channel sender.
+ /// extracted metadata is ingested through the underlying state.
///
/// # Returns
///
@@ -77,7 +77,8 @@ impl<SqsClientManager: AwsClientManagerType<Client>, State: SqsListenerState>
}
}
- /// Processes the SQS response to extract S3 object metadata and send it to the channel sender.
+ /// Processes the SQS response to extract S3 object metadata and ingest it through the
+ /// underlying state.
///
/// # NOTE
///
@@ -263,7 +264,7 @@ impl<State: SqsListenerState> SqsListener<State> {
/// Creates and spawns a new [`SqsListener`] backed by a [`Task`].
///
/// This function spawns a series of [`Task`]. Each spawned task will listen to SQS messages,
- /// extract relevant S3 object metadata, and send the metadata to the provided channel sender.
+ /// extract relevant S3 object metadata, and ingest the metadata through the provided state.
///
/// # Type parameters
/// |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.