chore(webui): Upgrade Antd to 6.x and remove @ant-design/v5-patch-for-react-19 (resolves #1894).#2084
Draft
junhaoliao wants to merge 1 commit intoy-scope:mainfrom
Draft
chore(webui): Upgrade Antd to 6.x and remove @ant-design/v5-patch-for-react-19 (resolves #1894).#2084junhaoliao wants to merge 1 commit intoy-scope:mainfrom
junhaoliao wants to merge 1 commit intoy-scope:mainfrom
Conversation
…-react-19 (resolves y-scope#1894).
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade
antdfrom v5 (^5.27.5) to v6 (^6.3.1) and remove the@ant-design/v5-patch-for-react-19compatibility shim, which is no longer needed since Antd 6.x has native React 19 support.Antd v6 migration notes
Reviewed the v5 → v6 migration guide and the
v6 changelog in full. The following is a summary of significant v6 changes and how they affect the codebase:
Breaking changes addressed in this PR:
ThemeConfig.cssVarno longer acceptsboolean— removedcssVar: true.Alert.message→Alert.title— renamed inQueryDrawer.tsx.notification'smessage→title— renamed inuseUpdateStateWithMetadata.ts.@ant-design/v5-patch-for-react-19unnecessary with native React 19 support — removed.Checklist
breaking change.
Validation performed
Start CLP, compress data, and verify the webui renders correctly.
Command:
Output:
Command:
Output:
Verify that the webui renders correctly with Antd 6.x — Ingest page, Search
page, and search execution.
Used headless Chromium via Playwright to capture screenshots of:
http://localhost:4000): Dashboard cards (Space Savings, Time Range,Uncompressed/Compressed Size), compression form (Paths TreeSelect, Dataset Input,
Timestamp Key Input, Unstructured Logs Checkbox, Submit Button), and Compression Jobs
table all render correctly. The completed compression job shows the correct status badge.
http://localhost:4000/search): Dataset Select, query Input, casesensitivity toggle Button, time range DatePicker, Search Button, results Timeline
(chart.js), and results Table all render correctly.
successfully, showing the "Success" result status with Typography and the timeline
updated to the search time range.
All UI components render identically to v5 with no layout regressions.