feat(log-ingestor): Submit compression jobs by metadata IDs (addresses #2018)#2087
Draft
jonathan-imanu wants to merge 7 commits intoy-scope:mainfrom
Draft
feat(log-ingestor): Submit compression jobs by metadata IDs (addresses #2018)#2087jonathan-imanu wants to merge 7 commits intoy-scope:mainfrom
jonathan-imanu wants to merge 7 commits intoy-scope:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HOLD OFF ON REVIEWING UNTIL #2082 IS MERGED.
This PR is the builds off of #2082 and completes the proposal in #2018.
In #2082, we added support for a new input that contains the ingestor_job_id & metadata_ids so the scheduler can directly query the ingested_s3_object_metadata table for the metadata. This input was unused when #2082 was merged since the
log-ingestorwas still submitting S3InputConfig.This PR updates the
log-ingestorto submit the newS3ObjectMetadataInputConfig. To achieve this, this PR:CompressionBufferEntryto associate object size with metadata_id and updates interfaces of listener and submitter to use this typelog-ingestorChecklist
breaking change.
Validation performed
task tests:rust-all