Skip to content

build(core): Lock CMake version to < 4 across all platforms to avoid third-party library compilation issues. #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 2, 2025
Merged

build(core): Lock CMake version to < 4 across all platforms to avoid third-party library compilation issues. #796

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
341c485
build(core): Lock CMake to v3.31.6 on macOS to mitigate #793.
kirkrodrigues Apr 1, 2025
eb903f9
Fix argument order.
kirkrodrigues Apr 1, 2025
954a769
Remove unnecessary argument.
kirkrodrigues Apr 1, 2025
9268619
Enforce to use cmake version under 4.0.0. y-scope#795
Bill-hbrhbr Apr 1, 2025
0ddd87d
Fix MacOS missing variable def
Bill-hbrhbr Apr 1, 2025
51d88db
Apply suggestions from code review
Bill-hbrhbr Apr 2, 2025
38e4311
Rename check cmake version script file
Bill-hbrhbr Apr 2, 2025
9ecc868
Use cmake -E capabilities which does not rely on custom parsing
Bill-hbrhbr Apr 2, 2025
3869dcd
Remove quotes around version string during jq
Bill-hbrhbr Apr 2, 2025
a9f0991
Use long option
Bill-hbrhbr Apr 2, 2025
614688d
Revert to using cmake major version
Bill-hbrhbr Apr 2, 2025
cb88d87
Use number comparison
Bill-hbrhbr Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions components/core/tools/scripts/lib_install/centos-stream-9/install-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@ script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

"${script_dir}/install-prebuilt-packages.sh"
"${script_dir}/install-packages-from-source.sh"

# TODO: https://github.com/y-scope/clp/issues/795
"${script_dir}/../check-cmake.sh"
14 changes: 14 additions & 0 deletions components/core/tools/scripts/lib_install/check-cmake.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
#!/usr/bin/env bash

# Exit on error
set -e

# Get the installed cmake version string
cmake_version=$(cmake --version | head -n1 | awk '{print $3}')
cmake_major_version=$(echo "$cmake_version" | cut -d. -f1)

# Check if version is 4.0 or higher
if [[ "$cmake_major_version" -ge "4" ]]; then
echo "CMake version $cmake_version is not supported (>= 4.0)."
exit 1
fi
12 changes: 11 additions & 1 deletion components/core/tools/scripts/lib_install/macos/install-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,15 @@ set -e
set -u

brew update

# Install CMake v3.31.6 since we're using yaml-cpp that doesn't yet support CMake v4 yet
cmake_formula_path=/tmp/cmake.rb
curl --fail --show-error --location --output "${cmake_formula_path}" \
https://raw.githubusercontent.com/Homebrew/homebrew-core/b4e46db74e74a8c1650b38b1da222284ce1ec5ce/Formula/c/cmake.rb
brew install --formula "${cmake_formula_path}"

brew install \
boost \
cmake \
coreutils \
fmt \
gcc \
Expand All @@ -32,3 +38,7 @@ brew install \
if ! command -v pkg-config ; then
brew install pkg-config
fi

# TODO: https://github.com/y-scope/clp/issues/795
script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
"${script_dir}/../check-cmake.sh"
7 changes: 5 additions & 2 deletions components/core/tools/scripts/lib_install/ubuntu-focal/install-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@ set -u

script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

"$script_dir"/install-prebuilt-packages.sh
"$script_dir"/install-packages-from-source.sh
"${script_dir}/install-prebuilt-packages.sh"
"${script_dir}/install-packages-from-source.sh"

# TODO: https://github.com/y-scope/clp/issues/795
"${script_dir}/../check-cmake.sh"
7 changes: 5 additions & 2 deletions components/core/tools/scripts/lib_install/ubuntu-jammy/install-all.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,8 @@ set -u

script_dir="$( cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"

"$script_dir"/install-prebuilt-packages.sh
"$script_dir"/install-packages-from-source.sh
"${script_dir}/install-prebuilt-packages.sh"
"${script_dir}/install-packages-from-source.sh"

# TODO: https://github.com/y-scope/clp/issues/795
"${script_dir}/../check-cmake.sh"
Loading