forked from prestodb/presto
-
Notifications
You must be signed in to change notification settings - Fork 3
feat(presto-clp): Add a plan optimizer to push down supported filters to CLP. #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wraymo
merged 7 commits into
y-scope:release-0.293-clp-connector
from
wraymo:plan_optimizer
Jun 24, 2025
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e94e218
add plan optimizer for clp connector
wraymo b0fc053
apply review suggestions
wraymo b6ee2ea
fix inconsistent variable name and remove Optional from test cases
wraymo 544ab52
apply review suggestions
wraymo 7dcc7fc
rename definition to pushDownExpression in ClpExpression
wraymo 636d35e
apply review suggestion
wraymo 537c424
fix a name in comments
wraymo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
78 changes: 78 additions & 0 deletions
78
presto-clp/src/main/java/com/facebook/presto/plugin/clp/ClpExpression.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.facebook.presto.plugin.clp; | ||
|
|
||
| import com.facebook.presto.spi.relation.RowExpression; | ||
|
|
||
| import java.util.Optional; | ||
|
|
||
| /** | ||
| * Represents the result of converting a Presto RowExpression into a CLP-compatible KQL query. | ||
| * There are three possible cases: | ||
| * 1. The entire RowExpression is convertible to KQL: `definition` is set, `remainingExpression` is empty. | ||
| * 2. Part of the RowExpression is convertible: the KQL part is stored in `definition`, | ||
| * and the remaining untranslatable part is stored in `remainingExpression`. | ||
| * 3. None of the expression is convertible: the full RowExpression is stored in `remainingExpression`, | ||
| * and `definition` is empty. | ||
| */ | ||
| public class ClpExpression | ||
| { | ||
| // Optional KQL query string representing the fully or partially translatable part of the expression. | ||
| private final Optional<String> definition; | ||
kirkrodrigues marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| // The remaining (non-translatable) portion of the RowExpression, if any. | ||
| private final Optional<RowExpression> remainingExpression; | ||
|
|
||
| public ClpExpression(String definition, RowExpression remainingExpression) | ||
| { | ||
| this.definition = Optional.ofNullable(definition); | ||
| this.remainingExpression = Optional.ofNullable(remainingExpression); | ||
| } | ||
|
|
||
| /** | ||
| * Creates an empty ClpExpression (no KQL definition, no remaining expression). | ||
wraymo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| */ | ||
| public ClpExpression() | ||
| { | ||
| this(null, null); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a ClpExpression from a fully translatable KQL string. | ||
wraymo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| * @param definition | ||
| */ | ||
| public ClpExpression(String definition) | ||
| { | ||
| this(definition, null); | ||
| } | ||
|
|
||
| /** | ||
| * Creates a ClpExpression from a non-translatable RowExpression. | ||
wraymo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * @param remainingExpression | ||
| */ | ||
| public ClpExpression(RowExpression remainingExpression) | ||
| { | ||
| this(null, remainingExpression); | ||
| } | ||
|
|
||
| public Optional<String> getDefinition() | ||
| { | ||
| return definition; | ||
| } | ||
|
|
||
| public Optional<RowExpression> getRemainingExpression() | ||
| { | ||
| return remainingExpression; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.