forked from prestodb/presto
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Add support for defining and using specific columns for metadata filtering. #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
anlowee
merged 19 commits into
y-scope:release-0.293-clp-connector
from
anlowee:xwei/metadata-filter-v2
Jul 7, 2025
Merged
Changes from 17 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
948ccc0
feat: Add metadata filtering based on archive-level timestamp.
anlowee e530913
Address review comments
anlowee b0e35cc
Update docs
anlowee ee181b8
Fix one of ray comment
anlowee a9c4d8d
Address comments
anlowee 616e889
Address comments
anlowee ed8e2b4
Address comments
anlowee d944577
Fix maven checks
anlowee e0e74ac
Fix
anlowee 3c73569
Fix
anlowee 25840c5
Address comments
anlowee 08cf54e
Apply some coderabbitai comments
anlowee 5b29dca
Address comments
anlowee 7b7811b
Update presto-docs/src/main/sphinx/connector/clp.rst
anlowee 3d3eda4
Apply suggestions from code review
anlowee e033951
Address follow up
anlowee a8dd013
Merge branch 'release-0.293-clp-connector' into xwei/metadata-filter-v2
anlowee 305acd6
Address comments
anlowee f8b7eaf
Merge branch 'xwei/metadata-filter-v2' of github.com:anlowee/presto i…
anlowee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
LGTM! Consistent configuration property implementation.
The new
metadataFilterConfigproperty follows the established pattern with proper getter/setter methods and @config annotation.Consider adding validation for the metadata filter config path, similar to how
metadataTablePrefixis validated:@Config("clp.metadata-filter-config") public ClpConfig setMetadataFilterConfig(String metadataFilterConfig) { + if (metadataFilterConfig != null && !metadataFilterConfig.trim().isEmpty()) { + // Validate file path format or existence if needed + } this.metadataFilterConfig = metadataFilterConfig; return this; }Also applies to: 111-121
🤖 Prompt for AI Agents