forked from prestodb/presto
-
Notifications
You must be signed in to change notification settings - Fork 3
ci: Add GitHub workflows to build and publish coordinator runtime, worker runtime, and worker development environment container images. #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kirkrodrigues
merged 31 commits into
y-scope:release-0.293-clp-connector
from
anlowee:xwei/add-release-image-publish-workflow
Jul 22, 2025
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
4f23c7b
Init
48dff13
Temporaryily remove all other workflows for faster testing
9bd9207
Try fix
4997a02
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee d74b885
Fix
4815351
Fix
e7fe20c
Still build the runtime image when updating the PR, but only publish …
fc2cc18
Build worker image
cc2c510
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee 60dd19d
Restore workflows
a534bec
Remove the uncessary action
9e17bc0
Use docker build-and-push action
aeb4e48
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee dbb28fa
Fix
1e69681
Fix
4ca014c
Fix
fec665a
Fix
20a7054
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee 283b751
Fix
64983f0
Merge branch 'xwei/add-release-image-publish-workflow' of github.com:…
a6ebbaa
Fix
5ca0420
Apply suggestions from code review
anlowee fa06d23
Address comments
d120672
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee 4c90aad
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee 3b76c12
Address comments
b55aeda
Merge branch 'xwei/add-release-image-publish-workflow' of github.com:…
74787c7
Remove TODO
313a648
Address comments
47b9c10
Merge branch 'release-0.293-clp-connector' into xwei/add-release-imag…
anlowee ceaa809
Minor refactoring.
kirkrodrigues File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| name: "prestissimo-worker-images-build" | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
|
|
||
| jobs: | ||
| prestissimo-worker-images-build: | ||
| name: "prestissimo-worker-images-build" | ||
| runs-on: "ubuntu-22.04" | ||
| steps: | ||
| - uses: "actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683" | ||
| with: | ||
| submodules: "recursive" | ||
|
|
||
| - name: "Login to image registry" | ||
| uses: "docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772" | ||
| with: | ||
| registry: "ghcr.io" | ||
| username: "${{github.actor}}" | ||
| password: "${{secrets.GITHUB_TOKEN}}" | ||
|
|
||
| - name: "Set up metadata for dependency image" | ||
| id: "metadata-deps-image" | ||
| uses: "docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804" | ||
| with: | ||
| images: "ghcr.io/${{github.repository}}/prestissimo-worker-dev-env" | ||
| tags: "type=raw,value=dev" | ||
|
|
||
| - name: "Build and push dependency image" | ||
| uses: "docker/build-push-action@471d1dc4e07e5cdedd4c2171150001c434f0b7a4" | ||
| with: | ||
| context: "./presto-native-execution" | ||
| file: "./presto-native-execution/scripts/dockerfiles/ubuntu-22.04-dependency.dockerfile" | ||
| push: >- | ||
| ${{github.event_name != 'pull_request' | ||
| && github.ref == 'refs/heads/release-0.293-clp-connector'}} | ||
| tags: "${{steps.metadata-deps-image.outputs.tags}}" | ||
| labels: "${{steps.metadata-deps-image.outputs.labels}}" | ||
|
|
||
| - name: "Set up metadata for runtime image" | ||
| id: "metadata-runtime-image" | ||
| uses: "docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804" | ||
| with: | ||
| images: "ghcr.io/${{github.repository}}/prestissimo-worker" | ||
| tags: "type=raw,value=dev" | ||
|
|
||
| - name: "Get number of cores" | ||
| id: "get-cores" | ||
| run: |- | ||
| echo "num_cores=$(nproc)" >> $GITHUB_OUTPUT | ||
| - name: "Build and push runtime image" | ||
| uses: "docker/build-push-action@471d1dc4e07e5cdedd4c2171150001c434f0b7a4" | ||
| with: | ||
| build-args: |- | ||
| BASE_IMAGE=ubuntu:22.04 | ||
| DEPENDENCY_IMAGE=${{steps.metadata-deps-image.outputs.tags}} | ||
| EXTRA_CMAKE_FLAGS=-DPRESTO_ENABLE_TESTING=OFF \ | ||
| -DPRESTO_ENABLE_PARQUET=ON \ | ||
| -DPRESTO_ENABLE_S3=ON | ||
| NUM_THREADS=${{steps.get-cores.outputs.num_cores}} | ||
| OSNAME=ubuntu | ||
| context: "./presto-native-execution" | ||
| file: "./presto-native-execution/scripts/dockerfiles/prestissimo-runtime.dockerfile" | ||
| push: >- | ||
| ${{github.event_name != 'pull_request' | ||
| && github.ref == 'refs/heads/release-0.293-clp-connector'}} | ||
| tags: "${{steps.metadata-runtime-image.outputs.tags}}" | ||
| labels: "${{steps.metadata-runtime-image.outputs.labels}}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Mixed pinning style: commit SHAs here, version tags elsewhere
This workflow pins actions to SHAs while
maven-checks.ymluses version tags (@v4,@v5). Pick one convention (preferably SHA pinning) across all workflows for consistency and supply-chain safety.🤖 Prompt for AI Agents