-
Notifications
You must be signed in to change notification settings - Fork 3
docs: Add k8s setup instructions. #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-0.293-clp-connector
Are you sure you want to change the base?
Changes from 9 commits
5f0eb8c
5bae0ce
c82f6eb
ba8cdf6
80ec62d
e40f329
6cafbfc
17d7d31
8aa5cc1
c8666a4
d730404
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| demo-assets/clp-config.yml | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # Patterns to ignore when building packages. | ||
| # This supports shell glob matching, relative path matching, and | ||
| # negation (prefixed with !). Only one pattern per line. | ||
| .DS_Store | ||
| # Common VCS dirs | ||
| .git/ | ||
| .gitignore | ||
| .bzr/ | ||
| .bzrignore | ||
| .hg/ | ||
| .hgignore | ||
| .svn/ | ||
| # Common backup files | ||
| *.swp | ||
| *.bak | ||
| *.tmp | ||
| *.orig | ||
| *~ | ||
|
|
||
|
Comment on lines
+4
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Minor style nit – drop the leading dots for Helm-relative paths Unlike 🤖 Prompt for AI Agents |
||
| # Various IDEs | ||
| .project | ||
| .idea/ | ||
| *.tmproj | ||
| .vscode/ | ||
|
|
||
| # Demo assets | ||
| /demo-assets/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| apiVersion: v2 | ||
| name: presto-velox | ||
| description: A Helm chart for Kubernetes | ||
|
|
||
| # A chart can be either an 'application' or a 'library' chart. | ||
| # | ||
| # Application charts are a collection of templates that can be packaged into versioned archives | ||
| # to be deployed. | ||
| # | ||
| # Library charts provide useful utilities or functions for the chart developer. They're included as | ||
| # a dependency of application charts to inject those utilities and functions into the rendering | ||
| # pipeline. Library charts do not define any templates and therefore cannot be deployed. | ||
| type: application | ||
|
|
||
| # This is the chart version. This version number should be incremented each time you make changes | ||
| # to the chart and its templates, including the app version. | ||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | ||
| version: 0.1.0 | ||
|
|
||
| # This is the version number of the application being deployed. This version number should be | ||
| # incremented each time you make changes to the application. Versions are not expected to | ||
| # follow Semantic Versioning. They should reflect the version the application is using. | ||
| # It is recommended to use it with quotes. | ||
| appVersion: "1.16.0" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| # Setup local K8s cluster for presto + clp | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Keep a single H1 and demote the others -# Launch clp-package
+# ## Launch clp-package
...
-# Create k8s Cluster
+# ## Create k8s Cluster
...
-# Working with helm chart
+# ## Working with helm chart
...
-# Delete k8s Cluster
+# ## Delete k8s ClusterAlso applies to: 26-26, 53-53, 59-59, 94-94 🤖 Prompt for AI Agents |
||
|
|
||
| ## Install docker | ||
|
|
||
| Follow the guide here: [docker] | ||
|
|
||
| ## Install kubectl | ||
|
|
||
| `kubectl` is the command-line tool for interacting with Kubernetes clusters. You will use it to | ||
| manage and inspect your k3d cluster. | ||
|
|
||
| Follow the guide here: [kubectl] | ||
|
|
||
| ## Install k3d | ||
|
|
||
| k3d is a lightweight wrapper to run k3s (Rancher Lab's minimal Kubernetes distribution) in docker. | ||
|
|
||
| Follow the guide here: [k3d] | ||
|
|
||
| ## Install Helm | ||
|
|
||
| Helm is the package manager for Kubernetes. | ||
|
|
||
| Follow the guide here: [helm] | ||
|
|
||
| # Launch clp-package | ||
| 1. Find the clp-package for test on our official website [clp-json-v0.4.0]. We also put the dataset for demo here: `mongod-256MB-presto-clp.log.tar.gz`. | ||
|
|
||
| 2. Untar it. | ||
|
|
||
| 3. Replace the content of `/path/to/clp-json-package/etc/clp-config.yml` with the output of `demo-assets/init.sh <ip_addr>` where the `<ip_addr>` is the IP address of the host that you are running the clp-package. | ||
|
|
||
| 4. Launch: | ||
| ```bash | ||
| # You probably want to run in a 3.11 python environment | ||
| sbin/start-clp.sh | ||
| ``` | ||
|
Comment on lines
+31
to
+37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Insert blank lines around list items and fenced blocks 3. Replace the content …
-4. Launch:
-```bash
+#
+4. Launch:
+
+```bashApply the same pattern to the other ordered-list sections. 🧰 Tools🪛 markdownlint-cli2 (0.17.2)33-33: Lists should be surrounded by blank lines (MD032, blanks-around-lists) 34-34: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 🤖 Prompt for AI Agents |
||
|
|
||
| 5. Compress: | ||
| ```bash | ||
| # You can also use your own dataset | ||
| sbin/compress.sh --timestamp-key 't.dollar_sign_date' datasets/mongod-256MB-processed.log | ||
| ``` | ||
|
|
||
| 6. Use the following command to update the CLP metadata database so that the worker can find the archives in right place: | ||
| ```bash | ||
| # Install mysql-client if necessary | ||
| sudo apt update && sudo apt install -y mysql-client | ||
|
Comment on lines
+33
to
+48
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Surround list items and fenced blocks with blank lines Several ordered-list steps (e.g., 3–6) butt directly against code fences, triggering MD031/MD032 and rendering oddly. Insert a blank line before and after each fenced block and between list items. 🧰 Tools🪛 LanguageTool[uncategorized] ~45-~45: Possible missing article found. (AI_HYDRA_LEO_MISSING_THE) 🪛 markdownlint-cli2 (0.17.2)33-33: Lists should be surrounded by blank lines (MD032, blanks-around-lists) 34-34: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 39-39: Ordered list item prefix (MD029, ol-prefix) 39-39: Lists should be surrounded by blank lines (MD032, blanks-around-lists) 40-40: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 45-45: Ordered list item prefix (MD029, ol-prefix) 45-45: Lists should be surrounded by blank lines (MD032, blanks-around-lists) 46-46: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 🤖 Prompt for AI Agents |
||
| # Find the user and password in /path/to/clp-json-package/etc/credential.yml | ||
| mysql -h ${REPLACE_IP} -P 6001 -u ${REPLACE_USER} -p'${REPLACE_PASSWORD}' clp-db -e "UPDATE clp_datasets SET archive_storage_directory = '/var/data/archives/default';" | ||
| ``` | ||
|
Comment on lines
+45
to
+51
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Minor grammar fix for clarity -mysql … -e "UPDATE clp_datasets SET archive_storage_directory = '/var/data/archives/default';"
+mysql … -e "UPDATE clp_datasets SET archive_storage_directory = '/var/data/archives/default';"
^ add “the”
🧰 Tools🪛 LanguageTool[uncategorized] ~45-~45: Possible missing article found. (AI_HYDRA_LEO_MISSING_THE) 🪛 markdownlint-cli2 (0.17.2)45-45: Ordered list item prefix (MD029, ol-prefix) 45-45: Lists should be surrounded by blank lines (MD032, blanks-around-lists) 46-46: Fenced code blocks should be surrounded by blank lines (MD031, blanks-around-fences) 🤖 Prompt for AI Agents |
||
|
|
||
| # Create k8s Cluster | ||
| Create a local k8s cluster with port forwarding | ||
| ```bash | ||
| k3d cluster create yscope --servers 1 --agents 1 -v $(readlink -f /path/to/clp-json-package/var/data/archives):/var/data/archives | ||
| ``` | ||
|
|
||
| # Working with helm chart | ||
| ## Install | ||
| In `yscope-k8s/templates/presto/presto-coordinator-config.yaml`: | ||
| 1. replace the `${REPLACE_ME}` in `clp.metadata-db-url=jdbc:mysql://${REPLACE_ME}:6001` with the IP address of the host you are running the clp-package (basially match the IP address that you configured in the `etc/clp-config.yml` of the clp-package). | ||
| 2. replace the `${REPLACE_ME}` in `clp.metadata-db-user=${REPLACE_ME}` with the user stored in `/path/to/clp-json-package/etc/credential.yml`. | ||
| 3. replace the `${REPLACE_ME}` in `clp.metadata-db-password=${REPLACE_ME}` with the password stored in `/path/to/clp-json-package/etc/credential.yml`. | ||
|
|
||
| ```bash | ||
| cd yscope-k8s | ||
|
|
||
| helm template . | ||
|
|
||
| helm install demo . | ||
| ``` | ||
|
|
||
| ## Use cli: | ||
| After all containers are in "Running" states (check by `kubectl get pods`): | ||
| ```bash | ||
| kubectl port-forward service/presto-coordinator 8080:8080 | ||
| ``` | ||
|
|
||
| Then you can further forward the 8080 port to your local laptop, to access the Presto's WebUI by e.g., http://localhost:8080 | ||
|
|
||
| To use presto-cli: | ||
| ```bash | ||
| ./presto-cli-0.293-executable.jar --catalog clp --schema default --server localhost:8080 | ||
| ``` | ||
|
|
||
| Example query: | ||
| ``` | ||
| SELECT * FROM default LIMIT 1; | ||
| ``` | ||
|
Comment on lines
+88
to
+90
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Add language hint to SQL block The example query lacks a language tag, tripping MD040 and losing syntax highlighting. -```
+```sql
SELECT * FROM default LIMIT 1;In yscope-k8s/README.md around lines 88 to 90, the SQL code block is missing a |
||
|
|
||
| ## Uninstall | ||
| ```bash | ||
| helm uninstall demo | ||
| ``` | ||
|
|
||
| # Delete k8s Cluster | ||
| ```bash | ||
| k3d cluster delete yscope | ||
| ``` | ||
|
|
||
|
|
||
| [clp-json-v0.4.0]: https://github.com/y-scope/clp/releases/tag/v0.4.0 | ||
| [docker]: https://docs.docker.com/engine/install | ||
| [k3d]: https://k3d.io/stable/#installation | ||
| [kubectl]: https://kubernetes.io/docs/tasks/tools/#kubectl | ||
| [helm]: https://helm.sh/docs/intro/install/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| package: | ||
| storage_engine: "clp-s" | ||
| database: | ||
| type: "mariadb" | ||
| host: "${REPLACE_IP}" | ||
| port: 6001 | ||
| name: "clp-db" | ||
| query_scheduler: | ||
| host: "${REPLACE_IP}" | ||
| port: 6002 | ||
| jobs_poll_delay: 0.1 | ||
| num_archives_to_search_per_sub_job: 16 | ||
| logging_level: "INFO" | ||
| queue: | ||
| host: "${REPLACE_IP}" | ||
| port: 6003 | ||
| redis: | ||
| host: "${REPLACE_IP}" | ||
| port: 6004 | ||
| query_backend_database: 0 | ||
| compression_backend_database: 1 | ||
| reducer: | ||
| host: "${REPLACE_IP}" | ||
| base_port: 6100 | ||
| logging_level: "INFO" | ||
| upsert_interval: 100 | ||
| results_cache: | ||
| host: "${REPLACE_IP}" | ||
| port: 6005 | ||
| db_name: "clp-query-results" | ||
| stream_collection_name: "stream-files" | ||
| webui: | ||
| host: "localhost" | ||
| port: 6000 | ||
| logging_level: "INFO" | ||
| log_viewer_webui: | ||
| host: "localhost" | ||
| port: 6006 | ||
|
Comment on lines
+32
to
+38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Consider parameterizing Most services rely on the -webui:
- host: "localhost"
+webui:
+ host: "${REPLACE_IP}"
...
-log_viewer_webui:
- host: "localhost"
+log_viewer_webui:
+ host: "${REPLACE_IP}"🤖 Prompt for AI Agents |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
|
Comment on lines
+1
to
+2
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Enable safer Bash defaults Fail fast on any unexpected error or unset variable to avoid silently producing a partially-edited config. #!/usr/bin/env bash
+set -euo pipefail🤖 Prompt for AI Agents |
||
| if [ "$#" -ne 1 ]; then | ||
| echo "Usage: $0 <ip-address>" | ||
| exit 1 | ||
| fi | ||
|
|
||
| SCRIPT_PATH="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
|
|
||
| IP="$1" | ||
| FILE="${SCRIPT_PATH}/clp-config.yml" | ||
|
|
||
| cp "${FILE}.bak" "$FILE" | ||
|
|
||
| sed -i "s|\${REPLACE_IP}|$IP|g" "$FILE" | ||
|
Comment on lines
+13
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive)
The current one-argument form works on GNU sed; macOS requires an empty string after if sed --version >/dev/null 2>&1; then
sed -i "s|${REPLACE_IP}|$IP|g" "$FILE"
else
sed -i '' "s|${REPLACE_IP}|$IP|g" "$FILE"
fiThis prevents the script from failing on contributors’ Macs. 🤖 Prompt for AI Agents |
||
|
|
||
| echo "Replaced \${REPLACE_IP} with $IP in $FILE" | ||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,53 @@ | ||||||||||||||||||
| apiVersion: "v1" | ||||||||||||||||||
| kind: "ConfigMap" | ||||||||||||||||||
| metadata: | ||||||||||||||||||
| name: "presto-coordinator-config" | ||||||||||||||||||
| data: | ||||||||||||||||||
| clp.properties: | | ||||||||||||||||||
| connector.name=clp | ||||||||||||||||||
| clp.metadata-provider-type=mysql | ||||||||||||||||||
| clp.metadata-db-url=jdbc:mysql://${REPLACE_ME}:6001 | ||||||||||||||||||
| clp.metadata-db-name=clp-db | ||||||||||||||||||
| clp.metadata-db-user=${REPLACE_ME} | ||||||||||||||||||
| clp.metadata-db-password=${REPLACE_ME} | ||||||||||||||||||
| clp.metadata-table-prefix=clp_ | ||||||||||||||||||
| clp.split-provider-type=mysql | ||||||||||||||||||
| clp.metadata-filter-config=/opt/presto-server/etc/metadata-filter.json | ||||||||||||||||||
|
|
||||||||||||||||||
| config.properties: | | ||||||||||||||||||
| coordinator=true | ||||||||||||||||||
| node-scheduler.include-coordinator=false | ||||||||||||||||||
| http-server.http.port=8080 | ||||||||||||||||||
| query.max-memory=1GB | ||||||||||||||||||
| query.max-memory-per-node=1GB | ||||||||||||||||||
| discovery-server.enabled=true | ||||||||||||||||||
| discovery.uri=http://{{ .Values.presto.coordinator.serviceName }}:{{ .Values.presto.coordinator.httpPort }} | ||||||||||||||||||
| optimizer.optimize-hash-generation=false | ||||||||||||||||||
| regex-library=RE2J | ||||||||||||||||||
| use-alternative-function-signatures=true | ||||||||||||||||||
| inline-sql-functions=false | ||||||||||||||||||
| nested-data-serialization-enabled=false | ||||||||||||||||||
| native-execution-enabled=true | ||||||||||||||||||
|
|
||||||||||||||||||
| jvm.config: | | ||||||||||||||||||
| -server | ||||||||||||||||||
| -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005 | ||||||||||||||||||
| -Xmx4G | ||||||||||||||||||
|
Comment on lines
+33
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainOpen JDWP port ships in production image
🏁 Script executed: #!/bin/bash
# Check for JDWP flag in the Presto coordinator config
rg "agentlib:jdwp" -n yscope-k8s/templates/presto/presto-coordinator-config.yaml
# Look for an existing debug toggle in the chart values or templates
rg "\.Values\.debug" -n .Length of output: 184 🏁 Script executed: #!/bin/bash
# Search for any debug-related toggles in the chart values
rg "^[[:space:]]*debug" -n yscope-k8s/values.yaml
# Search for debug references across all templates
rg "debug" -n yscope-k8s/templatesLength of output: 86 Guard the JDWP JVM option behind a Helm debug toggle Prevent accidental exposure of the remote debugger by wrapping the • File: yscope-k8s/templates/presto/presto-coordinator-config.yaml (line 34) Suggested diff: @@ -32,6 +32,12 @@
-server
- -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005
-Xmx4G
+
+ {{- if .Values.debug.enabled }}
+ -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=*:5005
+ {{- end }}
+
# values.yaml
debug:
+ enabled: false📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
| -XX:+UseG1GC | ||||||||||||||||||
| -XX:G1HeapRegionSize=32M | ||||||||||||||||||
| -XX:+UseGCOverheadLimit | ||||||||||||||||||
| -XX:+ExplicitGCInvokesConcurrent | ||||||||||||||||||
| -XX:+HeapDumpOnOutOfMemoryError | ||||||||||||||||||
| -XX:+ExitOnOutOfMemoryError | ||||||||||||||||||
| -Djdk.attach.allowAttachSelf=true | ||||||||||||||||||
|
|
||||||||||||||||||
| log.properties: | | ||||||||||||||||||
| com.facebook.presto=DEBUG | ||||||||||||||||||
|
|
||||||||||||||||||
| metadata-filter.json: | | ||||||||||||||||||
| { | ||||||||||||||||||
| } | ||||||||||||||||||
|
|
||||||||||||||||||
| node.properties: | | ||||||||||||||||||
| node.environment=production | ||||||||||||||||||
| node.id={{ .Values.presto.coordinator.serviceName }} | ||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,75 @@ | ||||||||||||||||||
| apiVersion: "v1" | ||||||||||||||||||
| kind: "Pod" | ||||||||||||||||||
| metadata: | ||||||||||||||||||
| labels: | ||||||||||||||||||
| app: "{{ .Values.presto.coordinator.serviceName }}" | ||||||||||||||||||
| name: "{{ .Values.presto.coordinator.serviceName }}" | ||||||||||||||||||
| spec: | ||||||||||||||||||
|
Comment on lines
+1
to
+7
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Use a Deployment instead of a naked Pod A single-Pod manifest offers no self-healing. Swapping to a 🤖 Prompt for AI Agents |
||||||||||||||||||
| initContainers: | ||||||||||||||||||
| - name: "generate-configs" | ||||||||||||||||||
| image: "busybox" | ||||||||||||||||||
| command: ["/scripts/generate-configs.sh"] | ||||||||||||||||||
| volumeMounts: | ||||||||||||||||||
| - name: "presto-coordinator-config-script-volume" | ||||||||||||||||||
| mountPath: "/scripts" | ||||||||||||||||||
| - name: "presto-coordinator-config-dir-volume" | ||||||||||||||||||
| mountPath: "/opt/presto-server/etc" | ||||||||||||||||||
| - name: "presto-coordinator-config-volume" | ||||||||||||||||||
| mountPath: "/configs" | ||||||||||||||||||
| containers: | ||||||||||||||||||
| - name: "{{ .Values.presto.coordinator.serviceName }}" | ||||||||||||||||||
| image: "{{ .Values.presto.coordinator.image }}" | ||||||||||||||||||
| volumeMounts: | ||||||||||||||||||
| - name: "presto-coordinator-config-dir-volume" | ||||||||||||||||||
| mountPath: "/opt/presto-server/etc" | ||||||||||||||||||
| - name: "clp-archives-volume" | ||||||||||||||||||
| mountPath: "/var/data/archives" | ||||||||||||||||||
| volumes: | ||||||||||||||||||
| - name: "presto-coordinator-config-script-volume" | ||||||||||||||||||
| configMap: | ||||||||||||||||||
| name: "presto-coordinator-config-script" | ||||||||||||||||||
| defaultMode: 0755 | ||||||||||||||||||
| - name: "presto-coordinator-config-dir-volume" | ||||||||||||||||||
| emptyDir: {} | ||||||||||||||||||
| - name: "presto-coordinator-config-volume" | ||||||||||||||||||
| configMap: | ||||||||||||||||||
| name: "presto-coordinator-config" | ||||||||||||||||||
| - name: "clp-archives-volume" | ||||||||||||||||||
| hostPath: | ||||||||||||||||||
| path: "/var/data/archives" | ||||||||||||||||||
|
Comment on lines
+37
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) hostPath ties the pod to a single node 🤖 Prompt for AI Agents |
||||||||||||||||||
| --- | ||||||||||||||||||
| apiVersion: "v1" | ||||||||||||||||||
| kind: "Service" | ||||||||||||||||||
| metadata: | ||||||||||||||||||
| name: "{{ .Values.presto.coordinator.serviceName }}" | ||||||||||||||||||
| labels: | ||||||||||||||||||
| app: "{{ .Values.presto.coordinator.serviceName }}" | ||||||||||||||||||
| spec: | ||||||||||||||||||
| type: "ClusterIP" | ||||||||||||||||||
| ports: | ||||||||||||||||||
| - name: "http" | ||||||||||||||||||
| port: {{ .Values.presto.coordinator.httpPort }} | ||||||||||||||||||
| targetPort: {{ .Values.presto.coordinator.httpPort }} | ||||||||||||||||||
| selector: | ||||||||||||||||||
|
Comment on lines
+50
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Strip extra spaces inside Helm braces Extra spaces break YAMLlint ( - port: {{ .Values.presto.coordinator.httpPort }}
- targetPort: {{ .Values.presto.coordinator.httpPort }}
+ port: {{.Values.presto.coordinator.httpPort}}
+ targetPort: {{.Values.presto.coordinator.httpPort}}📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.37.1)[error] 55-55: too many spaces inside braces (braces) [error] 55-55: too many spaces inside braces (braces) [error] 56-56: too many spaces inside braces (braces) [error] 56-56: too many spaces inside braces (braces) 🤖 Prompt for AI Agents |
||||||||||||||||||
| app: "{{ .Values.presto.coordinator.serviceName }}" | ||||||||||||||||||
| --- | ||||||||||||||||||
| apiVersion: "v1" | ||||||||||||||||||
| kind: "ConfigMap" | ||||||||||||||||||
| metadata: | ||||||||||||||||||
| name: "presto-coordinator-config-script" | ||||||||||||||||||
| data: | ||||||||||||||||||
| generate-configs.sh: | | ||||||||||||||||||
| #!/bin/sh | ||||||||||||||||||
|
|
||||||||||||||||||
| # Exit on error | ||||||||||||||||||
| set -e | ||||||||||||||||||
|
|
||||||||||||||||||
| PRESTO_CONFIG_DIR="/opt/presto-server/etc" | ||||||||||||||||||
|
|
||||||||||||||||||
| # Setup the config directory hierarchy | ||||||||||||||||||
| mkdir -p ${PRESTO_CONFIG_DIR}/catalog | ||||||||||||||||||
|
|
||||||||||||||||||
| # Copy over files | ||||||||||||||||||
| cp /configs/* ${PRESTO_CONFIG_DIR} | ||||||||||||||||||
| mv ${PRESTO_CONFIG_DIR}/clp.properties ${PRESTO_CONFIG_DIR}/catalog | ||||||||||||||||||
|
|
||||||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,24 @@ | ||||||||||||
| apiVersion: "v1" | ||||||||||||
| kind: "ConfigMap" | ||||||||||||
| metadata: | ||||||||||||
| name: "presto-worker-config" | ||||||||||||
| data: | ||||||||||||
| clp.properties: | | ||||||||||||
| connector.name=clp | ||||||||||||
|
|
||||||||||||
| config.properties: | | ||||||||||||
| discovery.uri=http://{{ .Values.presto.coordinator.serviceName }}.default.svc.cluster.local:{{ .Values.presto.coordinator.httpPort }} | ||||||||||||
| presto.version=REPLACE_ME | ||||||||||||
| http-server.http.port={{ .Values.presto.worker.httpPort }} | ||||||||||||
| shutdown-onset-sec=1 | ||||||||||||
| register-test-functions=false | ||||||||||||
| runtime-metrics-collection-enabled=false | ||||||||||||
|
|
||||||||||||
| node.properties: | | ||||||||||||
| node.environment=production | ||||||||||||
| node.internal-address=REPLACE_ME | ||||||||||||
| node.location=testing-location | ||||||||||||
| node.id=REPLACE_ME | ||||||||||||
|
|
||||||||||||
| velox.properties: | | ||||||||||||
| mutable-config=true | ||||||||||||
|
Comment on lines
+23
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick (assertive) Add trailing newline to satisfy linters A missing newline at EOF violates POSIX text-file conventions and is flagged by YAMLlint. - mutable-config=true
+ mutable-config=true
+📝 Committable suggestion
Suggested change
🧰 Tools🪛 YAMLlint (1.37.1)[error] 24-24: no new line character at the end of file (new-line-at-end-of-file) 🤖 Prompt for AI Agents |
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick (assertive)
Add companion ignore rules for derived or editor artefacts
You already ignore the generated
clp-config.yml. It may be worth also excluding its backup variants and common editor swap files to keep the repo clean:📝 Committable suggestion
🤖 Prompt for AI Agents