Skip to content

Conversation

@anlowee
Copy link

@anlowee anlowee commented Sep 29, 2025

Description

This PR is to update the Velox submodule to sync the merged PRs y-scope/velox@12521a1 and y-scope/velox@6c826f7 to have the IR timestamp support and a syntax error in the Velox docs.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

Passed the CI.

Summary by CodeRabbit

  • Chores

    • Updated the preston-native-execution/velox subproject to a newer revision.
    • Synchronised internal dependency pointers to the latest commit.
  • Release Impact

    • No user-facing changes.
    • No functional or behavioural differences expected.
    • Existing features and workflows remain unchanged.
  • Compatibility

    • No changes to public interfaces or configurations.
    • No action required from users or administrators.

@coderabbitai
Copy link

coderabbitai bot commented Sep 29, 2025

Walkthrough

Updated the presto-native-execution/velox submodule reference to a new commit hash, with no detected changes to exported/public declarations or code behaviour.

Changes

Cohort / File(s) Summary
Submodule bump
presto-native-execution/velox
Updated submodule commit from 7ae51198424559a7ed6d245ce4c4214ef7047d9d to 12521a1b806bc371aa03cbd3eaa5cf6896d42102. No code changes in this repo’s files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • kirkrodrigues

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description provides essential information about the changes including what is being updated (Velox submodule), why (to sync IR timestamp support and fix a docs syntax error), and validation performed (CI passed). However, when compared to the repository's description template, several required sections are missing including "Motivation and Context", "Impact", "Test Plan", the template's specific "Contributor checklist" items, and the "Release Notes" section. The author used an alternative template structure that captures some key information but does not follow the repository's specified format. To resolve this issue, the author should update the PR description to follow the repository's template format. Specifically, they should add the "Motivation and Context" section explaining why this submodule update is needed, an "Impact" section describing any API or performance implications, a "Test Plan" section (expanding on the current validation note), complete the "Contributor checklist" items, and add a "Release Notes" section indicating either the release note content or using the "NO RELEASE NOTE" marker if not applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "feat: Upgrade velox submodule to y-scope/velox@12521a1" accurately and clearly describes the main change in the changeset. The raw summary confirms that the velox submodule revision has been updated to commit 12521a1, which is exactly what the title states. The title follows the conventional commit format, is concise, and provides sufficient specificity for teammates to understand the primary change when scanning the project history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 971443a and fff9e0c.

📒 Files selected for processing (1)
  • presto-native-execution/velox (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
  • GitHub Check: test (17.0.13, :presto-tests -P ci-only-resource-manager)
  • GitHub Check: test (17.0.13, :presto-tests -P ci-only-plan-determinism)
  • GitHub Check: test (8.0.442, :presto-main-base)
  • GitHub Check: test (17.0.13, :presto-tests -P ci-only-local-queries)
  • GitHub Check: test (8.0.442, :presto-tests -P ci-only-plan-determinism)
  • GitHub Check: test (17.0.13, :presto-tests -P presto-tests-general)
  • GitHub Check: test (17.0.13, :presto-tests -P ci-only-distributed-queries)
  • GitHub Check: test (17.0.13, :presto-tests -P ci-only-tpch-distributed-queries)
  • GitHub Check: test (17.0.13, :presto-tests -P presto-tests-execution-memory)
  • GitHub Check: test (8.0.442, :presto-main)
  • GitHub Check: test (8.0.442, :presto-tests -P presto-tests-execution-memory)
  • GitHub Check: test (8.0.442, :presto-tests -P ci-only-aggregation-queries)
  • GitHub Check: test (8.0.442, :presto-tests -P ci-only-distributed-non-hash-gen)
  • GitHub Check: maven-checks (8.0.442)
  • GitHub Check: maven-checks (17.0.13)
  • GitHub Check: prestissimo-worker-images-build
  • GitHub Check: prestocpp-linux-build-for-test
🔇 Additional comments (1)
presto-native-execution/velox (1)

1-1: Submodule update verified successfully.

The update advances the Velox submodule from commit 7ae5119 to 12521a1, including exactly 2 commits:

Both commits mentioned in the PR description are present, and no unintended commits are included.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Tip

🧪 Early access (models): enabled

We are currently testing Sonnet 4.5 code review models, which should lead to better review quality. However, this model may result in higher noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@anlowee anlowee closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants