-
Notifications
You must be signed in to change notification settings - Fork 9
feat(lint-configs): Disable clang-tidy's modernize-use-ranges check since we need to build with compilers that don't support ranges.
#77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughDisables the clang-tidy check modernize-use-ranges in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Co-authored-by: kirkrodrigues <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
exports/lint-configs/.clang-tidy(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: unit-tests (ubuntu-24.04)
- GitHub Check: unit-tests (macos-15)
- GitHub Check: unit-tests (ubuntu-22.04)
🔇 Additional comments (1)
exports/lint-configs/.clang-tidy (1)
29-29: Confirmed clang-tidy ≥ 19.1.0 is pinned, so modernize-use-ranges is recognised
Theexports/lint-configs/lint-requirements.txtfile specifiesclang-tidy>=19.1.0, which is well above the version that introduces themodernize-use-rangescheck. No additional CI workflow pinning was found, but this requirement ensures the check is known. Disabling onlymodernize-use-rangesis safe—approving these changes.
kirkrodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about:
feat(lint-configs): Disable clang-tidy's `modernize-use-ranges` check since we need to build with compilers that don't support ranges.
modernize-use-ranges check.modernize-use-ranges check since we need to build with compilers that don't support ranges.
Description
To align with the lowered minimum compiler requirement (Clang 15) for Velox compatibility, we are disabling the
modernize-use-rangescheck in clang-tidy. This check enforces use ofstd::ranges, which is not fully supported in Clang 15.See also: y-scope/ystdlib-cpp#72
Checklist
breaking change.
Validation performed
Summary by CodeRabbit
No impact on performance or functionality; existing behaviour unchanged. Estimated review effort: Low.