Skip to content

Conversation

@Bill-hbrhbr
Copy link
Contributor

@Bill-hbrhbr Bill-hbrhbr commented Aug 12, 2025

Description

To align with the lowered minimum compiler requirement (Clang 15) for Velox compatibility, we are disabling the modernize-use-ranges check in clang-tidy. This check enforces use of std::ranges, which is not fully supported in Clang 15.

See also: y-scope/ystdlib-cpp#72

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Nothing to be tested.

Summary by CodeRabbit

  • New Features
    • No user-facing changes in this release.
  • Chores
    • Updated static analysis settings to disable a noisy modernisation rule, reducing false positives and streamlining reviews.
  • Documentation
    • Added an explanatory note about the rationale for disabling the rule to help maintainers.

No impact on performance or functionality; existing behaviour unchanged. Estimated review effort: Low.

@Bill-hbrhbr Bill-hbrhbr requested a review from a team as a code owner August 12, 2025 18:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 12, 2025

Walkthrough

Disables the clang-tidy check modernize-use-ranges in exports/lint-configs/.clang-tidy and adds two commented lines documenting the rationale. No other configuration or public declarations were changed.

Changes

Cohort / File(s) Summary of Changes
Clang-Tidy Configuration
exports/lint-configs/.clang-tidy
Added -modernize-use-ranges to the Checks list (disabling the check) and added two commented lines under Disabled checks explaining rationale related to C++20/ranges support on certain compilers. No other settings changed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • davidlion
  • kirkrodrigues
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3ac8cf and 192b63f.

📒 Files selected for processing (1)
  • exports/lint-configs/.clang-tidy (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: unit-tests (ubuntu-24.04)
  • GitHub Check: unit-tests (macos-15)
  • GitHub Check: unit-tests (ubuntu-22.04)
🔇 Additional comments (1)
exports/lint-configs/.clang-tidy (1)

29-29: Confirmed clang-tidy ≥ 19.1.0 is pinned, so modernize-use-ranges is recognised
The exports/lint-configs/lint-requirements.txt file specifies clang-tidy>=19.1.0, which is well above the version that introduces the modernize-use-ranges check. No additional CI workflow pinning was found, but this requirement ensures the check is known. Disabling only modernize-use-ranges is safe—approving these changes.

Copy link
Member

@kirkrodrigues kirkrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the PR title, how about:

feat(lint-configs): Disable clang-tidy's `modernize-use-ranges` check since we need to build with compilers that don't support ranges.

@Bill-hbrhbr Bill-hbrhbr changed the title feat(lint-configs): Disable clang-tidy modernize-use-ranges check. feat(lint-configs): Disable clang-tidy's modernize-use-ranges check since we need to build with compilers that don't support ranges. Aug 13, 2025
@Bill-hbrhbr Bill-hbrhbr merged commit e121a57 into y-scope:main Aug 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants