Skip to content

refactor(utils): Remove unused download progress handling. #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junhaoliao merged 7 commits into from
Feb 12, 2025
Merged

refactor(utils): Remove unused download progress handling. #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b955cb
refactor(http-utils): Refactor download progress handling.
junhaoliao Feb 7, 2025
56c6f94
Add missing empty line.
junhaoliao Feb 7, 2025
2480118
Add missing empty lines.
junhaoliao Feb 7, 2025
6d52210
Rename variable for clarity in progress callback signatures.
junhaoliao Feb 7, 2025
7f38cf5
Add loading progress prints in the console.
junhaoliao Feb 12, 2025
231c924
Remove onProgress callback from getUint8ArrayFrom()
junhaoliao Feb 12, 2025
99c0fd7
Revert unrelated formatting.
junhaoliao Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/LogFileManager/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ const loadFile = async (fileSrc: FileSrcType)
let fileData: Uint8Array;
if ("string" === typeof fileSrc) {
fileName = getBasenameFromUrlOrDefault(fileSrc);
fileData = await getUint8ArrayFrom(fileSrc, () => null);
fileData = await getUint8ArrayFrom(fileSrc);
} else {
fileName = fileSrc.name;
fileData = new Uint8Array(await fileSrc.arrayBuffer());
Expand Down
11 changes: 1 addition & 10 deletions src/utils/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import axios, {AxiosError} from "axios";


type ProgressCallback = (numBytesDownloaded:number, numBytesTotal:number) => void;

/**
* Converts an Axios error into a custom Error object.
*
Expand Down Expand Up @@ -36,21 +34,14 @@ const convertAxiosError = (e: AxiosError): Error => {
* Downloads (bypassing any caching) a file as a Uint8Array.
*
* @param fileUrl
* @param progressCallback
* @return The file's content.
* @throws {Error} if the download fails.
*/
const getUint8ArrayFrom = async (fileUrl: string, progressCallback: ProgressCallback)
const getUint8ArrayFrom = async (fileUrl: string)
: Promise<Uint8Array> => {
try {
const {data} = await axios.get<ArrayBuffer>(fileUrl, {
responseType: "arraybuffer",
onDownloadProgress: ({loaded, total}) => {
if ("undefined" === typeof total) {
total = loaded;
}
progressCallback(loaded, total);
},
headers: {
"Cache-Control": "no-cache",
"Pragma": "no-cache",
Expand Down