Skip to content

Conversation

@Bill-hbrhbr
Copy link
Collaborator

@Bill-hbrhbr Bill-hbrhbr commented Jan 26, 2025

Description

  • Adds the lint:cpp-check and lint:cpp-fix tasks for formatting cpp header files and source files.

This PR mainly references the current practice in clp-ffi-py, and has cleaned up the sources section of each cpp-related tasks.

Validation performed

  • New task workflows succeed in detecting and fixing CMake files.

@Bill-hbrhbr Bill-hbrhbr self-assigned this Jan 26, 2025
@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion January 26, 2025 23:56
Copy link
Member

@davidlion davidlion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per offline discussion, additionally other changes/fixes regarding deps and venv are on the way.

@Bill-hbrhbr Bill-hbrhbr requested a review from davidlion January 27, 2025 09:00
@davidlion davidlion changed the title chore: Add Taskfile tasks to lint CPP files. chore: Add Taskfile tasks to lint C++ files. Jan 27, 2025
@davidlion davidlion merged commit e3d296a into y-scope:main Jan 27, 2025
3 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the add-cpp-lint branch February 3, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants