-
Notifications
You must be signed in to change notification settings - Fork 7
build: Add Catch2 dependency. #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
5 tasks
davidlion
requested changes
Feb 18, 2025
Bill-hbrhbr
commented
Feb 18, 2025
Collaborator
Author
Bill-hbrhbr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replied to all comments. Implementations will come shortly after.
davidlion
requested changes
Feb 20, 2025
davidlion
reviewed
Feb 20, 2025
Bill-hbrhbr
commented
Feb 20, 2025
davidlion
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
highest-order-bit: task
build:allensures that all dependencies are installed before buildingystdlib-cppitself, and it should trigger a re-run whenever there's a dependency change.Catch2dependency with the newest cmake and remote tasks inyscope-dev-utils.ystdlib-cppwith the newest versions inyscope-dev-utils.Catch2unit test target.submodulesas a potential folder to exclude when linting yaml files inystdlib-cpp. Now every non-project file resides inbuildexcept foryscope-dev-utils.lint:venvtask to comply with the arglist of new checksum tasks inyscope-dev-utils..clang-formatinystdlib-cpp/srcfor header includes reorder rules.As discussed offline, we are going to resolve the unnecessarily long dependency installation logs in the future.
Checklist
breaking change.
Validation performed