Skip to content

Conversation

@Bill-hbrhbr
Copy link
Collaborator

@Bill-hbrhbr Bill-hbrhbr commented Feb 11, 2025

Description

highest-order-bit: task build:all ensures that all dependencies are installed before building ystdlib-cpp itself, and it should trigger a re-run whenever there's a dependency change.

  • Download and install Catch2 dependency with the newest cmake and remote tasks in yscope-dev-utils.
  • Replace the current cmake config and build tasks in ystdlib-cpp with the newest versions in yscope-dev-utils.
  • Change the dummy target to a Catch2 unit test target.
  • Remove submodules as a potential folder to exclude when linting yaml files in ystdlib-cpp. Now every non-project file resides in build except for yscope-dev-utils.
  • Update the lint:venv task to comply with the arglist of new checksum tasks in yscope-dev-utils.
  • Add .clang-format in ystdlib-cpp/src for header includes reorder rules.

As discussed offline, we are going to resolve the unnecessarily long dependency installation logs in the future.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • The new unit test target builds and runs succcessfully.

@Bill-hbrhbr Bill-hbrhbr changed the title chore: Task dep chore: Add Catch2 dependency and manage its installation with Taskfile workflows. Feb 12, 2025
@Bill-hbrhbr Bill-hbrhbr marked this pull request as ready for review February 12, 2025 00:50
Copy link
Collaborator Author

@Bill-hbrhbr Bill-hbrhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replied to all comments. Implementations will come shortly after.

@davidlion davidlion changed the title chore: Add Catch2 dependency and manage its installation with Taskfile workflows. build: Add Catch2 dependency. Feb 20, 2025
@davidlion davidlion merged commit dde5732 into y-scope:main Feb 20, 2025
7 checks passed
@Bill-hbrhbr Bill-hbrhbr deleted the task-dep branch February 20, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants