refactor(error_handling): Move ErrorCategory definitions from header to source to reduce scope.

[Bill-hbrhbr]

Description

As discussed here, ErrorCategory classes don't need to be exposed in the header files.

Checklist

• The PR satisfies the contribution guidelines.
• This is a breaking change and that has been indicated in the PR title, OR this isn't a
  breaking change.
• Necessary docs have been updated, OR no docs need to be updated.

Validation performed

• unit tests pass.

Summary by CodeRabbit

• Refactor
  • Streamlined and consolidated error handling definitions to create a more concise and consistent public interface, reducing redundancy and improving maintainability. These improvements enhance the clarity and efficiency of error reporting for a smoother user experience. The update does not alter external functionality but lays a more robust foundation for error processing.

[coderabbitai]

Walkthrough

The changes involve the introduction of type aliases for AlwaysSuccessErrorCategory and BinaryErrorCategory in the C++ test source file, replacing the previous direct usage of full namespace paths. In contrast, the header file has had the declarations for these aliases removed, indicating a shift in how error category types are managed within the codebase.

Changes

File	Change Summary
src/ystdlib/error_handling/test/types.cpp	Added type alias definitions for AlwaysSuccessErrorCategory and BinaryErrorCategory using the ErrorCategory template to simplify namespace references.
src/ystdlib/error_handling/test/types.hpp	Removed the type alias declarations for AlwaysSuccessErrorCategory and BinaryErrorCategory.

Possibly related PRs

• feat(error_handling): Port error_handling library and related unit tests from CLP core. #28: Addresses similar modifications in type alias definitions for AlwaysSuccessErrorCategory and BinaryErrorCategory, directly impacting the implementation at a code level.

Suggested reviewers

• kirkrodrigues
• LinZhihao-723
• davidlion

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbf12c8 and 2f94d3d.

📒 Files selected for processing (1)

• src/ystdlib/error_handling/test/types.cpp (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/ystdlib/error_handling/test/types.cpp

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.