-
Notifications
You must be signed in to change notification settings - Fork 7
fix(taskfiles): Enable globstar in main taskfile so that **/* works properly in shell commands; Enable pipefail in main taskfile.
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
taskfile.yaml(1 hunks)
🔇 Additional comments (1)
taskfile.yaml (1)
3-3: Enable strict shell error handling withset -uandpipefail.
This will cause any use of unset variables to error out and ensure that pipeline failures aren’t silently ignored, improving robustness of your task commands.
Description
This PR mirrors y-scope/clp#900.
Checklist
breaking change.
Validation performed
Summary by CodeRabbit