Skip to content

feat(wasm): Add initial CMake build system and zstd-wasm target.#2

Merged
junhaoliao merged 4 commits intoy-scope:mainfrom
junhaoliao:wasm
Sep 10, 2025
Merged

feat(wasm): Add initial CMake build system and zstd-wasm target.#2
junhaoliao merged 4 commits intoy-scope:mainfrom
junhaoliao:wasm

Conversation

@junhaoliao
Copy link
Member

Description

A prototype for the project is at https://github.com/junhaoliao/zstd-ffi-js/tree/prototype

  1. Add deps setup tasks to download zstd sources and generate the single-file library as instructed at https://github.com/facebook/zstd/blob/22b44831637be02bff6a63f85e88671e4cb70460/build/single_file_libs/README.md
  2. Add CMakeLists.txt which includes the zstd-wasm target.
  3. Add tasks for building the target.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  1. Built the target with task or task zstd-wasm and observed no build error.

@junhaoliao junhaoliao requested a review from a team as a code owner September 9, 2025 05:07
@junhaoliao junhaoliao requested a review from hoophalab September 9, 2025 05:08
hoophalab
hoophalab previously approved these changes Sep 9, 2025
Copy link

@hoophalab hoophalab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry just one more nitpick in the doc and the taskfile. xD

EXCLUDE_PATTERNS: *emsdk_checksum_exclude_paths
INCLUDE_PATTERNS: ["{{.OUTPUT_DIR}}"]

install-zstd:
Copy link

@hoophalab hoophalab Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this as download-zstd since it only downloads tarball but doesn't create a cmake settings file. This keeps consistent with :deps:download-zstd in the doc.

(Or we can just rename :deps:download-zstd as :deps:install-zstd in the doc)

Co-authored-by: hoophalab <200652805+hoophalab@users.noreply.github.com>
@junhaoliao junhaoliao requested a review from hoophalab September 9, 2025 18:28
@kirkrodrigues kirkrodrigues changed the title feat(wasm): Add initial CMake build system and zstd-wasm target. feat(wasm): Add initial CMake build system and zstd-wasm target. Sep 10, 2025
@junhaoliao junhaoliao merged commit 852992d into y-scope:main Sep 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants