Skip to content

Commit 0e7d21b

Browse files
committed
Docs: updated changelog and readme
1 parent de337c7 commit 0e7d21b

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased](https://github.com/yCodeTech/valet-windows/tree/master)
99

10+
## [3.1.2](https://github.com/yCodeTech/valet-windows/tree/v3.1.2) - 2024-05-17
11+
12+
### Fixed
13+
14+
- Fixed https://github.com/yCodeTech/valet-windows/issues/11 bug that couldn't find the PHP executable when trying to add the default when installing valet. It would fail to get the PHP when there is a space in the path like `c:/Program Files/php/`. Wrapping the path in quotes in the underlying cmd command fixes this.
15+
16+
- Fixed an issue with the `diagnose` command which was brought up in https://github.com/yCodeTech/valet-windows/issues/11. The command wasn't available if valet wasn't installed, and could never be installed because of the PHP bug above. Fixed this by always having `diagnose` command available whether valet is installed or not.
17+
1018
## [3.1.1](https://github.com/yCodeTech/valet-windows/tree/v3.1.1) - 2024-03-25
1119

1220
### Added

README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,9 @@ NOTE: Laravel Valet Windows 3 is **developed and tested to run on Windows 10**.
158158

159159
- If you don't have PHP installed, make sure to [install](https://windows.php.net/download) it.
160160

161-
Download the Zip file and unzip into `C:/php/`. You may use Thread Safe (TS), but Non-Thread Safe (NTS) is better for using PHP on the FastCGI protocol, which Valet uses.
161+
Download the Zip file and unzip into a directory of your choosing. The recommended directory is: `C:/php/`.
162+
163+
You may use Thread Safe (TS), but Non-Thread Safe (NTS) is better for using PHP on the FastCGI protocol, which Valet uses.
162164

163165
> For NTS binaries the widespread use case is interaction with a web server through the FastCGI protocol, utilizing no multithreading (but also for example CLI).
164166
@@ -363,6 +365,8 @@ PHP 7.4.33 from C:\php\7.4 has been added.
363365

364366
###### Furthermore, the details of the versions will be written to the config in a natural decending order that adheres to decimals. This means that when two minor versions (like 8.1.8 and 8.1.18) of an alias (8.1) are added, and the default PHP is then set to use the alias, then Valet will use the most recent version of the alias, which in this case would be 8.1.18.
365367

368+
###### Note: You may specify the path without quotes, but if the directory has spaces in like `C:/Program Files/php/7.4` then it _must_ be surrounded in quotes. Otherwise valet will encounter an error.
369+
366370
###### php:add --xdebug
367371

368372
`--xdebug` is a boolean option to optionally install Xdebug for the PHP being added. If the option is present, it's `true`, otherwise `false`.

0 commit comments

Comments
 (0)