fix(CVE-2020-7660): fix for RegExp.flags and Date.prototype.toISOString#207
Merged
redonkulus merged 2 commits intomainfrom Feb 27, 2026
Merged
fix(CVE-2020-7660): fix for RegExp.flags and Date.prototype.toISOString#207redonkulus merged 2 commits intomainfrom
redonkulus merged 2 commits intomainfrom
Conversation
okuryu
reviewed
Feb 25, 2026
okuryu
approved these changes
Feb 26, 2026
Collaborator
Author
|
@okuryu I published an advisory GHSA-5c6j-r48x-rmvq I also published the release on https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The fix for CVE-2020-7660 correctly sanitizes RegExp.source, but RegExp.flags is still interpolated directly into generated output without escaping or validation. This enables code injection when serialized output is evaluated.
A similar injection vector exists via Date.prototype.toISOString() on the same code path.
If an attacker can influence objects passed into serialize(), they can inject arbitrary JavaScript that executes when the serialized output is evaluated (e.g., via eval(), new Function(), or embedding in <script> tags).
Affected Versions
All versions from v1.0.0 through v7.0.2 appear to be affected.
Impact
Improper neutralization during code generation allows arbitrary JavaScript execution when the serialized output is evaluated. This represents an incomplete remediation of the vulnerability class originally addressed in CVE-2020-7660.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.