Skip to content

startSupervisors not work after stopSupervisors #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tedxia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

startSupervisors not work after stopSupervisors #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/com/yahoo/storm/yarn/StormMasterServerHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@
import java.net.UnknownHostException;
import java.util.List;
import java.util.Map;
import java.util.concurrent.atomic.AtomicInteger;

import backtype.storm.utils.Utils;
import org.apache.thrift7.TException;
import org.json.simple.JSONValue;
import org.slf4j.Logger;
Expand All @@ -38,12 +40,14 @@ public class StormMasterServerHandler implements StormMaster.Iface {
Map _storm_conf;
StormAMRMClient _client;
MasterServer _masterServer;
AtomicInteger curNumNeedSupervisors;

StormMasterServerHandler(@SuppressWarnings("rawtypes") Map storm_conf, StormAMRMClient client) {
_storm_conf = storm_conf;
setStormHostConf();
Util.rmNulls(_storm_conf);
_client = client;
curNumNeedSupervisors = new AtomicInteger(0);
}

void init(MasterServer masterServer) {
Expand Down Expand Up @@ -102,6 +106,7 @@ public void setStormConf(String storm_conf) throws TException {
@Override
public void addSupervisors(int number) throws TException {
LOG.info("adding "+number+" supervisors...");
curNumNeedSupervisors.addAndGet(number);
_client.addSupervisors(number);
}

Expand Down Expand Up @@ -215,7 +220,10 @@ public void stopUI() throws TException {
@Override
public void startSupervisors() throws TException {
LOG.info("starting supervisors...");
_client.startAllSupervisors();
if (!_client.supervisorsAreToRun()) {
_client.addSupervisors(curNumNeedSupervisors.get());
_client.startAllSupervisors();
}
}

@Override
Expand Down