Skip to content

Conversation

Seb33300
Copy link
Contributor

@Seb33300 Seb33300 commented Feb 19, 2025

We are trying to migrate our project from another export lib to yajra/laravel-datatables-export, but we want to do it progressively.
Unfortunately, the other lib requires PHPOffice 1, and the latest version of yajra/laravel-datatables-export now requires PHPOffice 2 resulting in conflicts if we want to install the latest version of yajra/laravel-datatables-export.

Few weeks ago, the phpoffice lib was upgraded to v2 to fix a vulnerability issue: #63

All security patches are now backported to the v1 branch so I think it's safe to allow both v1 and v2.
Latest security patches I found:

I tested on my local environment and 1.29.9 is still working properly with yajra/laravel-datatables-export.

Copy link

@yajra
Copy link
Owner

yajra commented Feb 19, 2025

As I recall, I think one of the breaking changes from v1 to v2 is on the config side:

https://github.com/yajra/laravel-datatables-export/blob/master/src/config/datatables-export.php#L3
https://github.com/yajra/laravel-datatables-export/blob/master/src/config/datatables-export.php#L80-L82

Can't test atm, but if you can confirm the compatibility then I can go ahead and merge this.

Thanks!

Repository owner deleted a comment from obyajra Feb 19, 2025
@Seb33300
Copy link
Contributor Author

Seb33300 commented Feb 19, 2025

They also exist in v1:
https://github.com/PHPOffice/PhpSpreadsheet/blob/ffb47b639649fc9c8a6fa67977a27b756592ed85/src/PhpSpreadsheet/Style/NumberFormat.php#L46-L80

image

@yajra yajra merged commit 17e8ddb into yajra:master Feb 19, 2025
7 checks passed
@yajra
Copy link
Owner

yajra commented Feb 19, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants