fix: allow phpoffice v1 #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to migrate our project from another export lib to
yajra/laravel-datatables-export
, but we want to do it progressively.Unfortunately, the other lib requires PHPOffice 1, and the latest version of
yajra/laravel-datatables-export
now requires PHPOffice 2 resulting in conflicts if we want to install the latest version ofyajra/laravel-datatables-export
.Few weeks ago, the phpoffice lib was upgraded to v2 to fix a vulnerability issue: #63
All security patches are now backported to the v1 branch so I think it's safe to allow both v1 and v2.
Latest security patches I found:
1.29.9
: https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/1.29.92.3.7
: https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/2.3.7I tested on my local environment and
1.29.9
is still working properly withyajra/laravel-datatables-export
.