fix: support for array notation #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seb33300
force-pushed
the
array-notation
branch
2 times, most recently
from
fa1025d to
48f034d
Compare
|
I converted as draft because I may have a more efficient way to implement this |
Seb33300
force-pushed
the
array-notation
branch
2 times, most recently
from
ae583fb to
827f887
Compare
Seb33300
commented
Jun 11, 2025
|
Ready for review! |
yajra
requested changes
Jun 11, 2025
There was a problem hiding this comment.
Change looks good. Can you please fix the failing static analysis?
Error: Binary operation "." between mixed and ''|'.*' results in an error.
------ ---------------------------------------------------------------------
Line Jobs/DataTableExportJob.php
------ ---------------------------------------------------------------------
236 Binary operation "." between mixed and ''|'.*' results in an error.
🪪 binaryOp.invalid
------ ---------------------------------------------------------------------
|
Fixed |
yajra
approved these changes
Jun 11, 2025
|
Released on https://github.com/yajra/laravel-datatables-export/releases/tag/v12.0.2 🚀 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That PR adds support for array notation in exports.
Before that PR, columns using the array notation were exported as empty columns.
Related to yajra/laravel-datatables#3243
Examples:
You can declare columns like this: