Skip to content

fix: unauthorized columns being displayed by builder #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2024
Merged

fix: unauthorized columns being displayed by builder #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Html/Options/HasColumns.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,11 @@ public function columns(array $columns): static

$this->collection->push(new Column($attributes));
} else {
$this->collection->push($value);

// Only add the column if it is authorized, otherwise ignore it.
if ($value->isAuthorized()) {
$this->collection->push($value);
}
}
}

Expand Down
15 changes: 15 additions & 0 deletions tests/BuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,4 +287,19 @@ public function it_has_editors()
]);
$this->assertCount(2, $builder->getEditors());
}

#[Test]
public function it_ignores_unauthorized_columns(): void
{
$builder = $this->getHtmlBuilder();

$builder->columns([
Column::makeIf(false)
->title('unauthorized_column'),

Column::make('authorized_column'),
]);

$this->assertCount(1, $builder->getColumns());
}
}
Loading