Skip to content

fix: change laravelcollective/html form to laravellux/html #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2025
Merged

fix: change laravelcollective/html form to laravellux/html #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"php": "^8.0.2",
"ext-json": "*",
"yajra/laravel-datatables-oracle": "^10.0",
"laravelcollective/html": "^6.3.0"
"laravellux/html": "^6.3.0"
},
"require-dev": {
"nunomaduro/larastan": "^2.1",
Expand Down
2 changes: 1 addition & 1 deletion src/Html/Builder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Yajra\DataTables\Html;

use Collective\Html\HtmlBuilder;
use LaravelLux\Html\HtmlBuilder;
use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\View\Factory;
use Illuminate\Support\Collection;
Expand Down Expand Up @@ -60,7 +60,7 @@
* @param Factory $view
* @param HtmlBuilder $html
*/
public function __construct(public Repository $config, public Factory $view, public HtmlBuilder $html)

Check failure on line 63 in src/Html/Builder.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1) 

Property Yajra\DataTables\Html\Builder::$html has unknown class LaravelLux\Html\HtmlBuilder as its type.

Check failure on line 63 in src/Html/Builder.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1) 

Property Yajra\DataTables\Html\Builder::$html has unknown class LaravelLux\Html\HtmlBuilder as its type.

Check failure on line 63 in src/Html/Builder.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1) 

Parameter $html of method Yajra\DataTables\Html\Builder::__construct() has invalid type LaravelLux\Html\HtmlBuilder.

Check failure on line 63 in src/Html/Builder.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1) 

Parameter $html of method Yajra\DataTables\Html\Builder::__construct() has invalid type LaravelLux\Html\HtmlBuilder.
{
/** @var array $defaults */
$defaults = $this->config->get('datatables-html.table', []);
Expand All @@ -83,7 +83,7 @@
public function scripts(string $script = null, array $attributes = ['type' => 'text/javascript']): HtmlString
{
$script = $script ?: $this->generateScripts();
$attributes = $this->html->attributes($attributes);

Check failure on line 86 in src/Html/Builder.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1) 

Call to method attributes() on an unknown class LaravelLux\Html\HtmlBuilder.

return new HtmlString("<script{$attributes}>$script</script>");
}
Expand Down Expand Up @@ -173,7 +173,7 @@
$this->setTableAttributes($attributes);

$th = $this->compileTableHeaders();
$htmlAttr = $this->html->attributes($this->tableAttributes);

Check failure on line 176 in src/Html/Builder.php

View workflow job for this annotation

GitHub Actions / Static Analysis with PHPStan (8.1) 

Call to method attributes() on an unknown class LaravelLux\Html\HtmlBuilder.

$tableHtml = '<table'.$htmlAttr.'>';
$searchHtml = $drawSearch ? '<tr class="search-filter">'.implode('',
Expand Down
2 changes: 1 addition & 1 deletion src/HtmlServiceProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

namespace Yajra\DataTables;

use Collective\Html\HtmlServiceProvider as CollectiveHtml;
use LaravelLux\Html\HtmlServiceProvider as CollectiveHtml;
use Illuminate\Support\ServiceProvider;

class HtmlServiceProvider extends ServiceProvider
Expand Down
Loading