Skip to content

Proposed resolution to the issue #114 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zulfequar wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Proposed resolution to the issue #114 #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf980c9
Move the entire if statement from the initState method to the build m…
Nov 30, 2023
a85a5fe
Initialize the badge's appearanceDisappearanceFadeAnimationEnabled fi…
Nov 30, 2023
59c2b23
Correct the spelling
Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,6 @@ From left to right:<br>

[Diagonal decoration](https://pub.dev/packages/diagonal_decoration)

[Yako Yheme Switch](https://pub.dev/packages/yako_theme_switch)
[Yako Theme Switch](https://pub.dev/packages/yako_theme_switch)

and more to come!
9 changes: 6 additions & 3 deletions lib/src/badge.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ class BadgeState extends State<Badge> with TickerProviderStateMixin {
parent: _animationController,
curve: widget.badgeAnimation.curve,
);
}

@override
Widget build(BuildContext context) {
if (widget.showBadge && widget.badgeAnimation.toAnimate) {
_animationController.forward();
_appearanceController.forward();
Expand All @@ -94,11 +97,11 @@ class BadgeState extends State<Badge> with TickerProviderStateMixin {
reverse: true,
);
}
} else {
_animationController.reset();
_appearanceController.reset();
}
}

@override
Widget build(BuildContext context) {
if (widget.child == null) {
return widget.ignorePointer
? IgnorePointer(child: _getBadge())
Expand Down
2 changes: 1 addition & 1 deletion lib/src/badge_animation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ class BadgeAnimation {
this.curve = Curves.easeOutCubic,
this.colorChangeAnimationCurve = Curves.linear,
this.colorChangeAnimationDuration = Duration.zero,
this.appearanceDisappearanceFadeAnimationEnabled = true,
this.appearanceDisappearanceFadeAnimationEnabled = false,
}) : animationType = BadgeAnimationType.scale,
sizeTransitionAxis = null,
sizeTransitionAxisAlignment = null,
Expand Down