Add support for Chinese (Traditional and Simplified) #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+lib/i18n/zh-*.json: * Language definition files, using new options * Differences: * A couple characters differ * Simplified has no word for trillion (because mainland China) lib/index.js: + Register zh-TW and zh-CN + New internal option: smallMeans10. Introduced to resolve issues where languages without 20, 30, etc as bases (because they use 10 as a unit instead) were not getting their "two tens" set properly. Should not really be set by user code. + New language option: joinSeparator allows changing the space between words to something else, like an empty string in Chinese's case. + New language option: prependZero implements Chinese style zero insertion * Cleaned up a bit test/index.test.js: + Tests for zh-TW + Tests for zh-CN (which end earlier than zh-TW - see comment at the end of the changes) README.md: + Documented new language and new language options * Cleaned up a bit .gitignore: + Some people (like me) develop on Visual Studio or VSCode bower.json, package.json: * Bump version to 0.12.0
1 similar comment
kevinlaiGH
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
joinSeparatorallows changing the space between words to something else, like an empty string in Chinese's case.prependZeroimplements Chinese style zero insertion