WIP: Add comprehensive tests for ellipsis preservation #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extensive test coverage to verify that ellipsis (...) characters are correctly preserved throughout all processing stages, addressing concerns raised in issue #946. This commit adds: - 18 test cases in ellipsisPreservation.test.ts covering output generation - 9 test cases in fileProcessContent.test.ts covering content processing Test coverage includes: - All output formats (XML/Handlebars, XML/XMLBuilder, JSON, Markdown, Plain) - Multiple programming languages (TypeScript, JavaScript, Go, Python) - Various spread operator patterns (array spread, object spread, rest parameters) - All processing options (compress, removeComments, removeEmptyLines, showLineNumbers) - Edge cases (multiple ellipsis, strings, template literals, standalone ellipsis) All 35 tests pass, confirming that ellipsis characters are never converted to single dots in any scenario. Related to #946
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #963 +/- ##
==========================================
+ Coverage 89.68% 89.71% +0.02%
==========================================
Files 111 111
Lines 7843 7843
Branches 1504 1505 +1
==========================================
+ Hits 7034 7036 +2
+ Misses 809 807 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add extensive test coverage to verify that ellipsis (
...) characters are correctly preserved throughout all processing stages.This PR addresses concerns raised in #946 by adding comprehensive tests that confirm ellipsis characters are never converted to single dots in any scenario.
Test Coverage
New Test Files
Test Scenarios
Test Results
Investigation Summary
After thorough investigation of the codebase, we found no code that converts
...to.in any processing stage:...............Related Issue
Related to #946
Checklist
npm run testnpm run lint