Conversation
This reverts commit a8fccfc.
unexport instruction tables
the motivation is to allow llvm merge the identical validation logic. for example, the validation logic for i32.add and i32.sub are identical. llvm doesn't merge functions if their pointers are taken. (in our case, for the "instructions" table.) todo: - implement read_insn_nocheck - do the same for multibyte instructions (or decide not to do)
This reverts commit 63abebd.
TOYWASM_PROCESS_INSN_WITH_SWITCH=ON
```
Segment __PAGEZERO: 4294967296 (zero fill)
Segment __TEXT: 274432
Section __text: 235703
Section __stubs: 510
Section __cstring: 14126
Section __const: 1584
Section __unwind_info: 5240
Section __eh_frame: 12984
total 270147
Segment __DATA_CONST: 12288
Section __got: 736
Section __const: 9824
total 10560
Segment __DATA: 4096
Section __data: 8
total 8
Segment __LINKEDIT: 57344
total 4295315456
```
TOYWASM_PROCESS_INSN_WITH_SWITCH=OFF
```
Segment __PAGEZERO: 4294967296 (zero fill)
Segment __TEXT: 397312
Section __text: 357991
Section __stubs: 510
Section __cstring: 14216
Section __const: 1584
Section __unwind_info: 5256
Section __eh_frame: 13016
total 392573
Segment __DATA_CONST: 28672
Section __got: 736
Section __const: 26784
total 27520
Segment __DATA: 4096
Section __data: 8
total 8
Segment __LINKEDIT: 69632
total 4295467008
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.