Adding new manifests and fixing old ones because of a lot of issues. #18
Adding new manifests and fixing old ones because of a lot of issues. #18SultankaReal wants to merge 5 commits intoyandex-cloud:mainfrom
Conversation
…e, PostgresqlUser. Fixing old ones because of a lot of issues. All manifests have been checked and tested.
…-examples Adding new manifests with MySQLDatabase, MySQLUser, PostgresqlDatabase, PostgresqlUser. Fixing old ones because of a lot of issues. All manifests have been checked and tested.
vaspahomov
left a comment
vaspahomov
left a comment
There was a problem hiding this comment.
Hi, Nursultan! Thanks for you contribution. I've leave some comments, would you mind fixing it please?
| spec: | ||
| forProvider: | ||
| name: example-registry | ||
| folderIdRef: |
There was a problem hiding this comment.
Let's leave refs here and everywhere. It's more correct way to make resource references with crossplane
There was a problem hiding this comment.
Fixed.
But sometimes users face with the issue when they use Refs (folderIdRef, networkIdRef, etc...).
For example, when they apply the manifest, they see something like this in 'kubectl describe':
**CannotResolveResourceReferences 7s (x2 over 7s) managed/vpc.yandex-cloud.jet.crossplane.io/v1alpha1, kind=network cannot resolve references: mg.Spec.ForProvider.FolderID: cannot get referenced resource: Folder.resourcemanager.yandex-cloud.jet.crossplane.io "b1g67uo02ppktpkktrpg" not found
That's why I leave comments for additional information to users that they can not only use Refs.
examples/iam/folderiambinding.yaml
Outdated
| folderIdRef: | ||
| name: example-folder | ||
| folderId: <your-folder-id> | ||
| role: admin # укажи требуемую роль |
There was a problem hiding this comment.
Let's use english in comments
examples/container/registry.yaml
Outdated
| kind: Registry | ||
| metadata: | ||
| name: example-registry | ||
| name: registry-1994 |
There was a problem hiding this comment.
Let's use example in names
examples/dns/recordset.yaml
Outdated
| ttl: 200 | ||
| data: | ||
| - "10.1.0.1" | ||
| - '<ip-address>' # тут должен быть ip-адрес |
There was a problem hiding this comment.
It's not valid filed value. It's beter to use valid values, and add descriptions in comments
examples/dns/zone.yaml
Outdated
| folderId: <your-folder-id> | ||
| name: yc-courses-1999 # укажи имя своей dns-зоны | ||
| public: true | ||
| zone: pushka.ga. # укажи свою dns-зону |
There was a problem hiding this comment.
I beleve that not all users will be allowed to create pushka.ga zone.
And example.com was made for testing purpose - https://www.iana.org/domains/reserved
examples/iam/folderiammember.yaml
Outdated
| kind: FolderIAMMember | ||
| metadata: | ||
| name: crossplane-preprod | ||
| name: lala19 |
There was a problem hiding this comment.
Let's use smth like folder-iam-member-example
examples/mdb/mongodbcluster.yaml
Outdated
| networkId: <your-network-id> | ||
| clusterConfig: | ||
| - version: "4.2" | ||
| - version: "4.4" # required either [4.4 4.2 4.0 3.6 5.0-enterprise 4.4-enterprise 5.0] |
There was a problem hiding this comment.
It's better to provide link on some site where supported versions described. It will always be updated without commits in repo
There was a problem hiding this comment.
Unfortunately, I didn't find the appropriate link for it. That's why I deleted these comments.
Fixing names to example-{resource_name}
|
Examples have been updated since; do you think this PR is still valuable? |
…listeners to master * commit '96e65a48b89c3c9a6eacf0118ae03ee01a49a348': Remove some old broken tests Reduce code duplication Update version Group listeners by IP and protocol
3 participants
Adding new manifests with MySQLDatabase, MySQLUser, PostgresqlDatabase, PostgresqlUser.
Fixing old ones because of a lot of issues.
All manifests have been checked and tested.