Enhancements to pyproject #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opportunity356
force-pushed
the
better-pyproject
branch
22 times, most recently
from
94cd53c to
03efac5
Compare
opportunity356
force-pushed
the
better-pyproject
branch
7 times, most recently
from
be6b47c to
5f9440d
Compare
opportunity356
force-pushed
the
better-pyproject
branch
5 times, most recently
from
1706256 to
7205e4b
Compare
opportunity356
commented
Dec 14, 2024
Contributor
Author
There was a problem hiding this comment.
autogenerated, no need to review
opportunity356
commented
Dec 16, 2024
| "isort>=5.13.2", | ||
| ] | ||
| genproto = [ | ||
| "grpcio-tools==1.59.3", |
Contributor
Author
There was a problem hiding this comment.
Strictly pinned versions for some packages used in lint and format checks, because newer versions produce new errors. Will relax these restrictions in next PR, where also will fix linting and formating errors
PeppaTheC
reviewed
Dec 16, 2024
pyproject.toml
Outdated
|
|
||
| [project] | ||
| name = "yandexcloud" | ||
| version = "0.328.0" |
Contributor
There was a problem hiding this comment.
а теперь эту версию руками менеджерить надо?
Contributor
Author
There was a problem hiding this comment.
если правильно настроил semversion, то нет, он сам будет обновлять как раньше
pyproject.toml
Outdated
| version = "0.328.0" | ||
| authors = [{name = "Yandex LLC", email = "[email protected]"}] | ||
| license = {text = "MIT"} | ||
| description = "The Yandex.Cloud official SDK" |
Contributor
There was a problem hiding this comment.
а почему мы Yandex.Cloud пишем в python sdk всегда через точку?
Contributor
Author
There was a problem hiding this comment.
Исторически так было. Поправил
PeppaTheC
approved these changes
Dec 16, 2024
added 8 commits
December 16, 2024 15:55
opportunity356
force-pushed
the
better-pyproject
branch
from
d33e7d9 to
67a91f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python setup.py installwill not work. Use these alternatives to install package from source: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#what-commands-should-be-used-instead)uv runin Makefile