Skip to content
2 changes: 1 addition & 1 deletion packages/yx_scope_flutter/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dev_dependencies:
flutter_test:
sdk: flutter
flutter_lints: ^2.0.0
custom_lint: ^0.5.3
custom_lint: ^0.6.8
yx_scope_linter: ^0.1.0

flutter:
Expand Down
2 changes: 1 addition & 1 deletion packages/yx_scope_linter/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,6 @@ dependencies:

dev_dependencies:
lints: ^2.0.0
custom_lint:
custom_lint: ^0.6.8
yx_scope_linter:
path: ..
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:analyzer/error/error.dart';
import 'package:analyzer/error/error.dart' hide LintCode;
import 'package:analyzer/error/listener.dart';
import 'package:custom_lint_builder/custom_lint_builder.dart';
import 'package:yx_scope_linter/src/extensions.dart';
Expand Down Expand Up @@ -33,11 +33,11 @@ class ConsiderDepSuffix extends DartLintRule {
continue;
}

reporter.reportErrorForToken(
reporter.atToken(
dep.nameToken,
_code.copyWith(
correctionMessage: 'Change the name to `${dep.name}$_suffix`',
),
dep.nameToken,
);
}
});
Expand Down
6 changes: 3 additions & 3 deletions packages/yx_scope_linter/lib/src/lints/dep_cycle.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'package:analyzer/error/error.dart';
import 'package:analyzer/error/error.dart' hide LintCode;
import 'package:analyzer/error/listener.dart';
import 'package:custom_lint_builder/custom_lint_builder.dart';
import 'package:yx_scope_linter/src/extensions.dart';
Expand Down Expand Up @@ -45,13 +45,13 @@ class DepCycle extends DartLintRule {
final cycleDeps =
cycle.map((e) => deps[e]).whereType<DepDeclaration>();
for (final dep in cycleDeps) {
reporter.reportErrorForToken(
reporter.atToken(
dep.nameToken,
_code.copyWith(
problemMessage:
'$_message: ${cycleDeps.map((e) => e.name).join(' <- ')}'
' <- ${cycleDeps.first.name}',
),
dep.nameToken,
);
}
}
Expand Down
10 changes: 4 additions & 6 deletions packages/yx_scope_linter/lib/src/lints/final_dep.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/error/error.dart';
import 'package:analyzer/error/error.dart' hide LintCode;
import 'package:analyzer/error/listener.dart';
import 'package:custom_lint_builder/custom_lint_builder.dart';
import 'package:yx_scope_linter/src/priority.dart';
Expand Down Expand Up @@ -30,12 +30,10 @@ class FinalDep extends DartLintRule {
final field = dep.field;

if (!field.fields.isFinal) {
reporter.reportErrorForToken(
_code,
reporter.atToken(
dep.nameToken,
[],
[],
field.fields,
_code,
data: field.fields,
);
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/error/error.dart';
import 'package:analyzer/error/error.dart' hide LintCode;
import 'package:analyzer/error/listener.dart';
import 'package:custom_lint_builder/custom_lint_builder.dart';
import 'package:yx_scope_linter/src/names.dart';
Expand Down Expand Up @@ -47,7 +47,10 @@ class PassAsyncLifecycleInInitializeQueue extends DartLintRule {
continue;
}
if (!queueDeps.contains(dep.name)) {
reporter.reportErrorForToken(_code, dep.nameToken);
reporter.atToken(
dep.nameToken,
_code,
);
}
}
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'package:analyzer/dart/ast/ast.dart';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/dart/element/type.dart';
import 'package:analyzer/error/error.dart';
import 'package:analyzer/error/error.dart' hide LintCode;
import 'package:analyzer/error/listener.dart';
import 'package:custom_lint_builder/custom_lint_builder.dart';
import 'package:yx_scope_linter/src/priority.dart';
Expand Down Expand Up @@ -51,12 +51,10 @@ class UseAsyncDepForAsyncLifecycle extends DartLintRule {
final implementsAsyncLifecycle =
asyncLifecycleType.isAssignableFromType(depClass.thisType);
if (implementsAsyncLifecycle) {
reporter.reportErrorForToken(
_code,
reporter.atToken(
methodInvocation.methodName.token,
[],
[],
methodInvocation,
_code,
data: methodInvocation,
);
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/yx_scope_linter/lib/src/utils.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import 'types.dart';
class ClassUtils {
static bool implementsInterface(ClassElement element, String ancestorName) =>
element.interfaces
.map((e) => e.getDisplayString(withNullability: false))
.map((e) => e.getDisplayString())
.contains(ancestorName);

static bool isScopeContainer(ClassDeclaration node) {
Expand Down
4 changes: 2 additions & 2 deletions packages/yx_scope_linter/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ environment:
sdk: '>=2.19.6 <4.0.0'

dependencies:
analyzer: ^5.13.0
analyzer: ^6.4.1
analyzer_plugin: ^0.11.2
custom_lint_builder: ^0.5.3
custom_lint_builder: ^0.6.2
yx_scope: ^1.0.0

dev_dependencies:
Expand Down