Closed
Conversation
wupididu
force-pushed
the
public_sealed_scope_state
branch
from
e893b6b to
a0e5567
Compare
Closed
kltsv
reviewed
May 16, 2025
| emitImmediately: emitImmediately, | ||
| ); | ||
|
|
||
| /// Subscribes to the state. |
Collaborator
There was a problem hiding this comment.
В доку к обычному listen стоит добавить, что он будет эмитить значение только на полное появление и исчезание скоупа, а в listenState — что будет эмитить на каждую смену состояния, можно так же сослаться на класс состояния.
| if (scope == null) { | ||
| throw ScopeError( | ||
| '$Container must not be null if scope state is $_scopeState', | ||
| '$Container must not be null if scope state is $state', |
Collaborator
There was a problem hiding this comment.
У стейта toString не переопределен, стоит это сделать, иначе тут будет некрасивый лог.
wupididu
force-pushed
the
public_sealed_scope_state
branch
from
0a86bef to
69e1d70
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Сейчас невозможно проверить статус создания/удаления скоупа. Поэтому экспортируем ScopeState, который отражает состояние скоупа.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=ru