Skip to content

fix: unknown-options-as-args should treat negated boolean as unknown when boolean-negation:false #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: unknown-options-as-args should treat negated boolean as unknown when boolean-negation:false #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f85e0c8
fix: unknown-options-as-args should treat negated boolean as unknown …
shadowspawn Jul 25, 2025
48a99d9
Merge branch 'main' into fix-no-negated-with-unknown
bcoe Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/yargs-parser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -981,7 +981,10 @@ export class YargsParser {
// e.g. '-a' or '--arg'
const normalFlag = /^-+([^=]+?)$/
// check the different types of flag styles, including negatedBoolean, a pattern defined near the start of the parse method
return !hasFlagsMatching(arg, flagWithEquals, negatedBoolean, normalFlag)
const patterns = [flagWithEquals, normalFlag];
if (configuration['boolean-negation'])
patterns.push(negatedBoolean);
return !hasFlagsMatching(arg, ...patterns)
}

// make a best effort to pick a default value
Expand Down
12 changes: 12 additions & 0 deletions test/yargs-parser.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3071,6 +3071,18 @@ describe('yargs-parser', function () {
knownArg: false
})
})
it('should ignore negated known options when boolean-negation:false', function () {
const argv = parser('--no-known-arg --no-unknown-arg', {
boolean: ['known-arg'],
configuration: {
'unknown-options-as-args': true,
'boolean-negation': false
}
})
argv.should.deep.equal({
_: ['--no-known-arg', '--no-unknown-arg']
})
})
it('should ignore unknown options in long format separated by space', function () {
const argv = parser('--known-arg a --unknown-arg b', {
string: ['known-arg'],
Expand Down