Skip to content

Conversation

@Boshen
Copy link
Collaborator

@Boshen Boshen commented Jun 26, 2025

This should be safe because because our usages of regexes do not have unicode patterns.

This reduces binary size of oxc-resolver from 2.2M to 1.6M.

This should be safe because because our usages of regexes do not have unicode patterns.

This reduces binary size of `oxc-resolver` from 2.2M to 1.6M.
@Boshen
Copy link
Collaborator Author

Boshen commented Jun 26, 2025

CompileError(InnerError(BuildError { kind: Syntax { pid: PatternID(0), err: Translate(Error { kind: UnicodePerlClassNotFound, pattern: "(const\\s+RAW_RUNTIME_STATE\\s*=\\s*|hydrateRuntimeState\\(JSON\\.parse\\()'", span: Span(Position(o: 6, l: 1, c: 7), Position(o: 8, l: 1, c: 9)) }) } }))

Looking at all our regex usages, I can rewrite them without a regex 🤔

@Boshen
Copy link
Collaborator Author

Boshen commented Jun 26, 2025

Previous attempt: #12

@Boshen Boshen closed this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant