Skip to content

perf: use fxhash #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

perf: use fxhash #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ serde = { version = "1", features = ["derive"] }
serde_json = "1"
serde_with = { version = "3", features = ["indexmap_2"] }
thiserror = "2"
rustc-hash = "2"

[dev-dependencies]
rstest = "0.25.0"
Expand Down
15 changes: 9 additions & 6 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,15 @@ mod util;
mod zip;

use std::{
collections::{HashMap, HashSet, hash_map::Entry},
collections::hash_map::Entry,
hash::BuildHasherDefault,
path::{Path, PathBuf},
};

use fancy_regex::Regex;
use indexmap::IndexMap;
use lazy_static::lazy_static;
use rustc_hash::{FxHashMap, FxHashSet, FxHasher};
use serde::{Deserialize, Serialize};
use serde_with::{DefaultOnNull, serde_as};

Expand Down Expand Up @@ -68,7 +70,7 @@ pub struct PackageInformation {
discard_from_lookup: bool,

#[serde_as(as = "Vec<(_, Option<_>)>")]
package_dependencies: HashMap<String, Option<PackageDependency>>,
package_dependencies: FxHashMap<String, Option<PackageDependency>>,
}

#[serde_as]
Expand All @@ -91,21 +93,21 @@ pub struct Manifest {
// "name": "@app/monorepo",
// "workspace:."
// }]
dependency_tree_roots: HashSet<PackageLocator>,
dependency_tree_roots: FxHashSet<PackageLocator>,

// fallbackPool: [[
// "@app/monorepo",
// "workspace:.",
// ]]
#[serde_as(as = "Vec<(_, _)>")]
fallback_pool: HashMap<String, Option<PackageDependency>>,
fallback_pool: FxHashMap<String, Option<PackageDependency>>,

// fallbackExclusionList: [[
// "@app/server",
// ["workspace:sources/server"],
// ]]
#[serde_as(as = "Vec<(_, _)>")]
fallback_exclusion_list: HashMap<String, HashSet<String>>,
fallback_exclusion_list: FxHashMap<String, FxHashSet<String>>,

// packageRegistryData: [
// [null, [
Expand All @@ -115,7 +117,8 @@ pub struct Manifest {
// }]
// ]
#[serde_as(as = "Vec<(DefaultOnNull<_>, Vec<(DefaultOnNull<_>, _)>)>")]
package_registry_data: HashMap<String, IndexMap<String, PackageInformation>>,
package_registry_data:
FxHashMap<String, IndexMap<String, PackageInformation, BuildHasherDefault<FxHasher>>>,
}

fn parse_scoped_package_name(specifier: &str) -> Option<(String, Option<String>)> {
Expand Down