Skip to content

refactor: remove unnecessary derive Serialize on Error #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

refactor: remove unnecessary derive Serialize on Error #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
use std::path::PathBuf;

use serde::Serialize;
use thiserror::Error;

use crate::PackageLocator;

#[derive(Debug, Clone, PartialEq, Serialize, Error)]
#[derive(Debug, Clone, PartialEq, Error)]
pub enum Error {
#[error(transparent)]
BadSpecifier(Box<BadSpecifier>),
Expand All @@ -23,21 +22,21 @@ pub enum Error {
MissingDependency(Box<MissingDependency>),
}

#[derive(Debug, Clone, PartialEq, Serialize, Error)]
#[derive(Debug, Clone, PartialEq, Error)]
#[error("{message}")]
pub struct BadSpecifier {
pub message: String,
pub specifier: String,
}

#[derive(Debug, Clone, PartialEq, Serialize, Error)]
#[derive(Debug, Clone, PartialEq, Error)]
#[error("{message}")]
pub struct FailedManifestHydration {
pub message: String,
pub manifest_path: PathBuf,
}

#[derive(Debug, Clone, PartialEq, Serialize, Error)]
#[derive(Debug, Clone, PartialEq, Error)]
#[error("{message}")]
pub struct MissingPeerDependency {
pub message: String,
Expand All @@ -51,7 +50,7 @@ pub struct MissingPeerDependency {
pub broken_ancestors: Vec<PackageLocator>,
}

#[derive(Debug, Clone, PartialEq, Serialize, Error)]
#[derive(Debug, Clone, PartialEq, Error)]
#[error("{message}")]
pub struct UndeclaredDependency {
pub message: String,
Expand All @@ -63,7 +62,7 @@ pub struct UndeclaredDependency {
pub issuer_path: PathBuf,
}

#[derive(Debug, Clone, PartialEq, Serialize, Error)]
#[derive(Debug, Clone, PartialEq, Error)]
#[error("{message}")]
pub struct MissingDependency {
pub message: String,
Expand Down