Fixes implicit folder detection #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zip archives may have directory entries baked within the archive:
Or they may be missing:
In that second case we try to normalize the archive so that in both cases we end up with
["node_modules/", "node_modules/left-pad/", "node_modules/left-pad/perf/"]in thedirsset. Unfortunately the logic is bogus and we're not going over the very last component; so in this case, we would be missing thenode_modules/left-pad/perf/entry.This is then causing issues when the package has a
package.jsonin said directory, which happens for example forunderscore(it contains anode_modules/underscore/modules/package.jsonfile with"type": "module").This PR fixes the issue and adds new tests.