Skip to content

Add failing test for root traversal #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged

Add failing test for root traversal #7

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87a4d46
Add failing test
mrginglymus Apr 23, 2025
b71b3cb
Fixes failing test
arcanis Apr 23, 2025
8318486
Adds & fix another test case when __virtual__ is at the root of the path
arcanis Apr 23, 2025
046014f
Moves rstest to dev dependencies
arcanis Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/fs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,6 +400,16 @@ mod tests {
"virtualSegments": ["b/__virtual__/foo-abcdef/1/c/foo.zip", "c/foo.zip"],
"zipPath": "bar"
}],
["/a/b/__virtual__/foo-abcdef/1/c/foo.zip/bar", {
"basePath": "/a",
"virtualSegments": ["b/__virtual__/foo-abcdef/1/c/foo.zip", "c/foo.zip"],
"zipPath": "bar"
}],
["/a/b/__virtual__/foo-abcdef/2/c/foo.zip/bar", {
"basePath": "/",
Copy link
Contributor Author

@mrginglymus mrginglymus Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I'd expect, however, the current behaviour is to return ""

"virtualSegments": ["a/b/__virtual__/foo-abcdef/2/c/foo.zip", "c/foo.zip"],
"zipPath": "bar"
}],
["./a/b/c/.zip", null],
["./a/b/c/foo.zipp", null],
["./a/b/c/foo.zip/bar/baz/qux.zip", {
Expand Down