Skip to content

Fix ".bin" not linked when preparing a git dependency #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2017
Merged

Fix ".bin" not linked when preparing a git dependency #3723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion __tests__/fetchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ test('GitFetcher.fetch with prepare script', async () => {
{
type: 'git',
reference: 'https://github.com/Volune/test-js-git-repo',
hash: '96e838bcc908ed424666b4b04efe802fd4c8bccd',
hash: '0e56593e326069ed4bcec8126bb48a1891215c57',
registry: 'npm',
},
(await Config.create()),
Expand All @@ -95,6 +95,8 @@ test('GitFetcher.fetch with prepare script', async () => {
expect(dependencyName).toBe('beeper');
// The file "prepare.js" is not in "files" list
expect(await fs.exists(path.join(dir, 'prepare.js'))).toBe(false);
// Check the dependency with a bin script was correctly executed
expect(await fs.exists(path.join(dir, 'testscript.output.txt'))).toBe(true);
// Check executed lifecycle scripts
expect(await fs.exists(path.join(dir, 'generated', 'preinstall'))).toBe(true);
expect(await fs.exists(path.join(dir, 'generated', 'install'))).toBe(true);
Expand Down
1 change: 1 addition & 0 deletions src/fetchers/git-fetcher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ export default class GitFetcher extends BaseFetcher {
const [prepareConfig, prepareLockFile] = await Promise.all([
Config.create(
{
binLinks: true,
cwd: prepareDirectory,
disablePrepublish: true,
},
Expand Down