Skip to content

Normalize manifest re dos #9202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Normalize manifest re dos #9202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9773187
Update hosted-git-resolver.js
mmmsssttt404 Jul 16, 2025
af396d5
Update hosted-git-resolver.js
mmmsssttt404 Jul 16, 2025
2a31bd1
Update hosted-git-resolver.js
mmmsssttt404 Aug 13, 2025
7e7902f
Update hosted-git-resolver.js
mmmsssttt404 Aug 13, 2025
f61d32d
Update normalize-manifest.js
mmmsssttt404 Aug 13, 2025
b0daafb
Update util.js
mmmsssttt404 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions __tests__/normalize-manifest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,3 +183,25 @@ function normalizePathDict(paths: mixed): ?{[key: string]: mixed} {

return out;
}

describe('util DOS regression', () => {
const MAX_MS = 500;

test('dos1', () => {
const person = '' + '<'.repeat(100000) + '\u0000';
const start = Date.now();
const parsed = util.parsePerson(person);
const duration = Date.now() - start;
expect(parsed).toEqual({});
expect(duration).toBeLessThan(MAX_MS);
});

test('dos2', () => {
const person = '' + '('.repeat(100000) + '\u0000';
const start = Date.now();
const parsed = util.parsePerson(person);
const duration = Date.now() - start;
expect(parsed).toEqual({});
expect(duration).toBeLessThan(MAX_MS);
});
});
4 changes: 2 additions & 2 deletions src/util/normalize-manifest/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ export function parsePerson(person: mixed): any {
}
}

const email = person.match(/<([^>]+)>/);
const email = person.match(/<([^<>]+)>/);
if (email) {
obj.email = email[1];
}

const url = person.match(/\(([^\)]+)\)/);
const url = person.match(/\(([^\(\)]+)\)/);
if (url) {
obj.url = url[1];
}
Expand Down