update ruby to 3.2 before end of normal maintenance#1581
Open
update ruby to 3.2 before end of normal maintenance#1581
Conversation
Member
|
Ruby 3.2+ になったら YJIT 有効化でパフォーマンスが向上するかも...!?!? 😆✨ cf. Ruby 3.3でYJITを今すぐ有効にすべき理由 |
Member
Author
|
CI が下記で落ちてました。FYI: html-proofer のバージョンを 5.0.0 から 5.0.8 にアップデートしたら直りました。 |
rakuda-san-desu
approved these changes
Feb 13, 2024
rakuda-san-desu
left a comment
There was a problem hiding this comment.
対応ありがとうございます!
良さそうです🙆♀️
rbenv local 3.2.3 の後 bundle install を問題なく実行でき、差分も出ませんでした。
Member
Author
|
@rakuda-san-desu 早速の確認ありがとうございます! |
Member
|
こちらご都合の良いタイミングでマージしていただければ...!! (>人< )✨ |
Collaborator
|
@nanophate こちらのプルリクはガイドの文面には影響しないので、急ぎではありませんが、とりあえずマージしていただいてもよさそうに思えます |
Member
Author
|
@hachi8833 ありがとうございます。 ウェブアプリ本体とバージョンの依存関係があり、それを解消した際にマージしたいと思います。 🙇 早めに対応しますので、お待ちいただけると幸いです...! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
やりたいこと
ruby 3.1 のノーマルメンテナンス終了が大体リリースから 3 年なので、例年通りであれば、2024-04-1 メンテナンス終了と思うので、ruby 3.2 に上げたい