Open
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request introduces the functionality to create highlights via a new Sequence diagram for create_highlightsequenceDiagram
participant Client
participant OmnivoreQL
participant GraphQL API
Client->>OmnivoreQL: create_highlight(article_id, annotation, highlight_type)
OmnivoreQL->>GraphQL API: execute(CreateHighlight, variables)
GraphQL API-->>OmnivoreQL: Response
OmnivoreQL-->>Client: Response
Updated class diagram for OmnivoreQLclassDiagram
class OmnivoreQL {
+create_highlight(article_id: str, annotation: str, highlight_type: Literal[\'HIGHLIGHT\', \'NOTE\'])
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey @Benature - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider generating the shortId and UUID on the server side to avoid potential conflicts.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
I'm afraid not. Here's the server log of omnivore-api |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #IssueNr
📑 Description
add a method
create_highlight✅ Checks
ℹ Additional Information
Summary by Sourcery
New Features:
create_highlightmethod to create highlights for articles.