Open
Conversation
Contributor
Author
How can we get |
Contributor
Author
1ff5f8b to
4df8f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial implementation of
renamedsupport. Note that I removed:args(paths)and made thegit statuscommand always run at the repository root. This causesfetcherto process the entire git status output every time it runs, which will obviously lead to performance issues.However, it seems we have no other choice: When using
:args(paths), the command never outputs renamed files, and since renames can occur across folders, it must be executed at the root directory.We might consider adding an option to let users decide whether to enable this feature, even at the cost of performance.