chore(mount): add core type definitions#93
Open
EnergoStalin wants to merge 13 commits intoyazi-rs:mainfrom
Open
chore(mount): add core type definitions#93EnergoStalin wants to merge 13 commits intoyazi-rs:mainfrom
EnergoStalin wants to merge 13 commits intoyazi-rs:mainfrom
Conversation
changes must be veeeery small
EnergoStalin
changed the title
Contributor
Author
|
And actually maybe treating it as new extension would be eaisier for both of us. Cause 500/20 sounds like a crazy distribution do we really want 25 pr's for that? Feels like at least 3 weeks would be lost on this. |
sxyazi
force-pushed
the
main
branch
2 times, most recently
from
1ff5f8b to
4df8f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #91
Since code becomes fairly large after adding sshfs support and full typing i decided to go with some convention to remember api's which will be fully introduced later.
Rename self.partitions to self.entries cause UI becomes generalized.
refresh -> __refresh to make it more stand out as something internal cause later it shares first argument with fstype.